[GitHub] [airflow] kaxil commented on a change in pull request #9419: Pylint fixes and deprecation of rare used methods in Connection

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #9419:
URL: https://github.com/apache/airflow/pull/9419#discussion_r443086868



##########
File path: UPDATING.md
##########
@@ -62,6 +62,29 @@ https://developers.google.com/style/inclusive-documentation
 
 -->
 
+### Deprecated method in Connection
+
+The Connection class has new deprecated methods.
+
+- Connection.parse_from_uri
+- Connection.log_info
+- Connection.debug_info
+
+You used to create a connection object in two ways

Review comment:
       ```suggestion
   Previously, users could create a connection object in two ways
   ```

##########
File path: UPDATING.md
##########
@@ -62,6 +62,29 @@ https://developers.google.com/style/inclusive-documentation
 
 -->
 
+### Deprecated method in Connection
+
+The Connection class has new deprecated methods.
+
+- Connection.parse_from_uri
+- Connection.log_info
+- Connection.debug_info
+
+You used to create a connection object in two ways
+```
+conn_1 = Connection(conn_id="conn_a", uri="mysql://AAA/")
+# or
+conn_2 = Connection(conn_id="conn_a")
+conn_2.parse_uri(uri="mysql://AAA/")
+```
+Now the second way is not supported.
+
+Instead of the log_info and debug_info method. You can read each field individually or use the
+default representation (`__repr__`).

Review comment:
       ```suggestion
   `Connection.log_info` and `Connection.debug_info` method have been deprecated. Read each Connection field individually or use the
   default representation (`__repr__`).
   ```

##########
File path: UPDATING.md
##########
@@ -62,6 +62,29 @@ https://developers.google.com/style/inclusive-documentation
 
 -->
 
+### Deprecated method in Connection
+
+The Connection class has new deprecated methods.
+
+- Connection.parse_from_uri
+- Connection.log_info
+- Connection.debug_info

Review comment:
       ```suggestion
   - `Connection.parse_from_uri`
   - `Connection.log_info`
   - `Connection.debug_info`
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org