You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "mike-jumper (via GitHub)" <gi...@apache.org> on 2024/04/25 21:18:55 UTC
[PR] GUACAMOLE-1289: Refactor Duo and authentication flow to instead leverage support for updating/replacing credentials. [guacamole-client]
mike-jumper opened a new pull request, #980:
URL: https://github.com/apache/guacamole-client/pull/980
This change builds off and refactors the changes from #966 to instead allow extensions to update (or even replace) the `Credentials` received by a user prior to authentication.
In the context of Duo, this allows the Duo extension to internally cache and restore the credentials that were originally received prior to redirecting the user to the Duo service, allowing the `${GUAC_USERNAME}` and `${GUAC_PASSWORD}` tokens to continue working as intended.
If acceptable, this is intended to supersede #973 and incorporates the same changes updating/removing old dependencies.
I have not yet tested these changes against Duo; I'll do that shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1289: Refactor Duo and authentication flow to instead leverage support for updating/replacing credentials. [guacamole-client]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on PR #980:
URL: https://github.com/apache/guacamole-client/pull/980#issuecomment-2080073531
> > Looks good to me. @jmuehlner or @aleitner, any comments/concerns on this one?
>
> I haven't had time to dig into it yet, but I trust you if you think it's good.
Having a look now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1289: Refactor Duo and authentication flow to instead leverage support for updating/replacing credentials. [guacamole-client]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on PR #980:
URL: https://github.com/apache/guacamole-client/pull/980#issuecomment-2079791363
> Looks good to me. @jmuehlner or @aleitner, any comments/concerns on this one?
I haven't had time to dig into it yet, but I trust you if you think it's good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1289: Refactor Duo and authentication flow to instead leverage support for updating/replacing credentials. [guacamole-client]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on PR #980:
URL: https://github.com/apache/guacamole-client/pull/980#issuecomment-2078301895
I'll see if I can throw some backward compatibility in here, too...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1289: Refactor Duo and authentication flow to instead leverage support for updating/replacing credentials. [guacamole-client]
Posted by "aleitner (via GitHub)" <gi...@apache.org>.
aleitner commented on PR #980:
URL: https://github.com/apache/guacamole-client/pull/980#issuecomment-2081756329
I love this. Much simpler and solves the problem my open pr was meant to solve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1289: Refactor Duo and authentication flow to instead leverage support for updating/replacing credentials. [guacamole-client]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on PR #980:
URL: https://github.com/apache/guacamole-client/pull/980#issuecomment-2078821635
Testing things out and seems to work well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1289: Refactor Duo and authentication flow to instead leverage support for updating/replacing credentials. [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #980:
URL: https://github.com/apache/guacamole-client/pull/980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1289: Refactor Duo and authentication flow to instead leverage support for updating/replacing credentials. [guacamole-client]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #980:
URL: https://github.com/apache/guacamole-client/pull/980#issuecomment-2080178811
Thanks @jmuehlner. I'll hold off on the merge for a day or two and let @aleitner have a chance to have a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1289: Refactor Duo and authentication flow to instead leverage support for updating/replacing credentials. [guacamole-client]
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper commented on PR #980:
URL: https://github.com/apache/guacamole-client/pull/980#issuecomment-2078333128
It's looking like backward compatibility isn't really possible. Users will simply need to update their Duo config or use an older version of the extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-1289: Refactor Duo and authentication flow to instead leverage support for updating/replacing credentials. [guacamole-client]
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on PR #980:
URL: https://github.com/apache/guacamole-client/pull/980#issuecomment-2080175025
> > > Looks good to me. @jmuehlner or @aleitner, any comments/concerns on this one?
> >
> >
> > I haven't had time to dig into it yet, but I trust you if you think it's good.
>
> Having a look now.
LGTM. Probably worth @aleitner having a look too, as he's the New Duo Guy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org