You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/24 10:57:13 UTC

[GitHub] [airflow] turbaszek commented on a change in pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline

turbaszek commented on a change in pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline
URL: https://github.com/apache/airflow/pull/7849#discussion_r397064575
 
 

 ##########
 File path: airflow/providers/google/cloud/hooks/datafusion.py
 ##########
 @@ -397,7 +400,13 @@ def start_pipeline(
             "DataPipelineWorkflow",
             "start",
         )
-        response = self._cdap_request(url=url, method="POST")
+
+        if runtime_args != None:
+            args = ast.literal_eval(runtime_args)
+        else:
+            args = None
+
+        response = self._cdap_request(url=url, method="POST", body=args)
 
 Review comment:
   Why pass `runtime_args` as a string? Can't we use `dict`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services