You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "Charlie Black (JIRA)" <ji...@apache.org> on 2019/03/20 20:56:00 UTC

[jira] [Resolved] (GEODE-5677) Remove _GEODE_FRIEND_STD_SHARED_PTR

     [ https://issues.apache.org/jira/browse/GEODE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charlie Black resolved GEODE-5677.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8.0

works on mac -If you find this closure in error please (re)open a ticket with the details and or submit a pull request with the fix.

> Remove _GEODE_FRIEND_STD_SHARED_PTR
> -----------------------------------
>
>                 Key: GEODE-5677
>                 URL: https://issues.apache.org/jira/browse/GEODE-5677
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Blake Bender
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.8.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> This caused us for a long time to delay upgrading to recent versions of XCode, and could easily be broken again by changes to what are supposed to be internal classes to the STL.  This definition is kind of a kludge to allow us to protect constructors of certain classes while still making them creatable via std::make_shared.  Rather than go to this length to protect developers from themselves, we'll make the constructors in question public and remove the macro altogether.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)