You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "findepi (via GitHub)" <gi...@apache.org> on 2024/08/28 15:15:41 UTC
[PR] Remove redundant argument and improve error message [datafusion]
findepi opened a new pull request, #12217:
URL: https://github.com/apache/datafusion/pull/12217
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Remove redundant argument and improve error message [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #12217:
URL: https://github.com/apache/datafusion/pull/12217#discussion_r1738895434
##########
datafusion/functions/src/string/common.rs:
##########
@@ -183,7 +181,7 @@ fn string_trim<'a, T: OffsetSizeTrait>(
}
other => {
exec_err!(
- "{trim_type} was called with {other} arguments. It requires at least 1 and at most 2."
+ "trim was called with {other} arguments. It requires at least 1 and at most 2."
Review Comment:
```suggestion
"Function TRIM was called with {other} arguments. It requires at least 1 and at most 2."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Remove redundant argument and improve error message [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #12217:
URL: https://github.com/apache/datafusion/pull/12217#discussion_r1738894945
##########
datafusion/functions/src/string/common.rs:
##########
@@ -129,14 +128,13 @@ fn string_view_trim<'a, T: OffsetSizeTrait>(
}
other => {
exec_err!(
- "{trim_type} was called with {other} arguments. It requires at least 1 and at most 2."
+ "trim was called with {other} arguments. It requires at least 1 and at most 2."
Review Comment:
```suggestion
"Function TRIM was called with {other} arguments. It requires at least 1 and at most 2."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Remove redundant argument and improve error message [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #12217:
URL: https://github.com/apache/datafusion/pull/12217#issuecomment-2320935624
@comphead would you want to take a look? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Remove redundant argument and improve error message [datafusion]
Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #12217:
URL: https://github.com/apache/datafusion/pull/12217#issuecomment-2322229090
thanks, updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Remove redundant argument and improve error message [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead merged PR #12217:
URL: https://github.com/apache/datafusion/pull/12217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org