You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eventmesh.apache.org by "Alonexc (via GitHub)" <gi...@apache.org> on 2023/06/09 02:06:55 UTC
[GitHub] [eventmesh] Alonexc opened a new issue, #4105: [Enhancement] Do some code optimization.[EventMeshTcpRetryer]
Alonexc opened a new issue, #4105:
URL: https://github.com/apache/eventmesh/issues/4105
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request



located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/session/retry/EventMeshTcpRetryer.java line 40,42,104,127
analysis and explanation:
a. Field may be 'final'
b. Either re-interrupt this method or rethrow the "InterruptedException" that can be caught here.
c. This block of commented-out lines of code should be removed.
### Describe the solution you'd like
a. add final
b. restore interrupted state

c. remove.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [I] [Enhancement] Do some code optimization.[EventMeshTcpRetryer] (eventmesh)
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 closed issue #4105: [Enhancement] Do some code optimization.[EventMeshTcpRetryer]
URL: https://github.com/apache/eventmesh/issues/4105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org