You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/12/15 13:34:38 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #3947: HBASE-26567 Remove IndexType from ChunkCreator

Apache9 commented on a change in pull request #3947:
URL: https://github.com/apache/hbase/pull/3947#discussion_r769629588



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChunkCreator.java
##########
@@ -134,51 +134,36 @@ public static ChunkCreator getInstance() {
     return instance;
   }
 
-  /**
-   * Creates and inits a chunk. The default implementation for a specific chunk size.
-   * @return the chunk that was initialized
-   */
-  Chunk getChunk(ChunkType chunkType) {
-    return getChunk(CompactingMemStore.IndexType.ARRAY_MAP, chunkType);

Review comment:
       This method has been called in MemStoreLABImpl.getNewExternalChunk, so we could pass in IndexType.ARRAY_MAP to the createChunk method finally?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org