You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/17 10:14:17 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #38283: [SPARK-40818][CONNECT] Add Intersect to Connect proto and DSL
HyukjinKwon opened a new pull request, #38283:
URL: https://github.com/apache/spark/pull/38283
### What changes were proposed in this pull request?
This PR supports `Intersect` to Connect proto and DSL.
### Why are the changes needed?
To improve proto API coverage.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unittest was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38283: [SPARK-40818][CONNECT] Add Intersect to Connect proto and DSL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38283:
URL: https://github.com/apache/spark/pull/38283#issuecomment-1281659504
Oops, sorry guys. Closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38283: [SPARK-40818][CONNECT] Add Intersect to Connect proto and DSL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38283:
URL: https://github.com/apache/spark/pull/38283#discussion_r997026516
##########
python/pyspark/sql/connect/proto/relations_pb2.pyi:
##########
@@ -70,6 +70,7 @@ class Relation(google.protobuf.message.Message):
AGGREGATE_FIELD_NUMBER: builtins.int
Review Comment:
I hope we can get this of these codes in the main repo ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38283: [SPARK-40818][CONNECT] Add Intersect to Connect proto and DSL
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38283:
URL: https://github.com/apache/spark/pull/38283#issuecomment-1280680178
you should regenerate the pb files now:
```
Start checking the generated codes in pyspark-connect.
RUN: /__w/spark/spark/connector/connect/dev/generate_protos.sh /tmp/tmpfq9npbm2
Different files: ['relations_pb2.py', 'relations_pb2.pyi']
Generated files for pyspark-connect are out of sync! Please run ./connector/connect/dev/generate_protos.sh
Error: Process completed with exit code 255.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38283: [SPARK-40818][CONNECT] Add Intersect to Connect proto and DSL
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38283:
URL: https://github.com/apache/spark/pull/38283#discussion_r997376731
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -41,6 +41,7 @@ message Relation {
Aggregate aggregate = 9;
SQL sql = 10;
LocalRelation local_relation = 11;
+ Intersect intersect = 12;
Review Comment:
Wait, don't we have a Union type that does this (e.g. from the set operations?)
@amaliujia ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38283: [SPARK-40818][CONNECT] Add Intersect to Connect proto and DSL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38283:
URL: https://github.com/apache/spark/pull/38283#discussion_r996878103
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -41,6 +41,7 @@ message Relation {
Aggregate aggregate = 9;
SQL sql = 10;
LocalRelation local_relation = 11;
+ Intersect intersect = 12;
Review Comment:
This conflicts with some other PRs. I will change this if other PRs are merged first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38283: [SPARK-40818][CONNECT] Add Intersect to Connect proto and DSL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38283:
URL: https://github.com/apache/spark/pull/38283#issuecomment-1280622733
cc @amaliujia @zhengruifeng PTAL when you find some time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38283: [SPARK-40818][CONNECT] Add Intersect to Connect proto and DSL
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38283:
URL: https://github.com/apache/spark/pull/38283#issuecomment-1281103056
oops sorry for it: this PR duplicates with https://github.com/apache/spark/pull/38166.
Basically people wants to merge Union, Intersect and Except with `is_all` and `by_name` together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38283: [SPARK-40818][CONNECT] Add Intersect to Connect proto and DSL
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38283: [SPARK-40818][CONNECT] Add Intersect to Connect proto and DSL
URL: https://github.com/apache/spark/pull/38283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org