[jira] [Commented] (TS-3932) TCP TOS not working

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986480#comment-14986480 ] 

ASF GitHub Bot commented on TS-3932:
------------------------------------

GitHub user pbchou opened a pull request:

    https://github.com/apache/trafficserver/pull/318

    Jira TS-3932 IP TOS field not set.

    For Jira TS-3932, added second call to Connection::apply_options() within Connection::connect() so that the IP TOS field will be set properly. The first call to apply_options() within Connect::open()
    does not set the IP TOS field properly since addr is not initialized at that time. If addr is not initialized then the IPv4 check within apply_options() will fail.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pbchou/trafficserver ts3932

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/318.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #318
    
----
commit 6f33312a0497db8da39bcb18736f1dbd8b390524
Author: pbchou <pb...@labs.att.com>
Date:   2015-11-03T01:34:38Z

    For Jira TS-3932, added second call to Connection::apply_options()
    within Connection::connect() so that the IP TOS field will be set
    properly. The first call to apply_options() within Connect::open()
    does not set the IP TOS field properly since the addr is not
    initialized at that time.

----


> TCP TOS not working
> -------------------
>
>                 Key: TS-3932
>                 URL: https://issues.apache.org/jira/browse/TS-3932
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Network
>    Affects Versions: 6.0.0
>            Reporter: Bryan Call
>              Labels: Regression
>             Fix For: 6.1.0
>
>
> jasonstrongman2016:
> In 5.3.0 the below works. However, seems to be broken in other
> releases. Including this one.
> # /opt/trafficserver60rc3/bin/traffic_ctl -V
> Apache Traffic Server - traffic_ctl - 6.0.0 - (build # 091616 on Sep
> 16 2015 at 16:49:13)
> # /opt/trafficserver60rc3/bin/traffic_ctl config match sock_packet_tos_out
> proxy.config.net.sock_packet_tos_out: 184
> #tcpdump
> 17:55:07.377780 IP (tos 0x0, ttl 64, id 45468, offset 0, flags [DF],
> proto TCP (6), length 60)
>    10.0.0.71.51306 > 74.125.227.196.80: Flags [S],



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)