You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ki...@apache.org on 2021/01/09 20:25:16 UTC
svn commit: r1885319 - in
/poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant: ./ util/
Author: kiwiwings
Date: Sat Jan 9 20:25:15 2021
New Revision: 1885319
URL: http://svn.apache.org/viewvc?rev=1885319&view=rev
Log:
Sonar fixes
JUnit5 test classes and methods should have default package visibility
Modified:
poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestBuildFile.java
poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntPrecision.java
poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSet.java
poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSetDoubleCell.java
poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntUserDefinedFunction.java
poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java
poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtil.java
Modified: poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestBuildFile.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestBuildFile.java?rev=1885319&r1=1885318&r2=1885319&view=diff
==============================================================================
--- poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestBuildFile.java (original)
+++ poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestBuildFile.java Sat Jan 9 20:25:15 2021
@@ -50,7 +50,7 @@ public class TestBuildFile {
@BeforeEach
- public void setUp() {
+ void setUp() {
String filename = TestBuildFile.getDataDir() + "/../src/excelant/testcases/org/apache/poi/ss/excelant/tests.xml";
int logLevel = Project.MSG_DEBUG;
@@ -76,7 +76,7 @@ public class TestBuildFile {
* test target depend on it.
*/
@AfterEach
- public void tearDown() {
+ void tearDown() {
if (project == null) {
/*
* Maybe the BuildFileTest was subclassed and there is
@@ -100,21 +100,21 @@ public class TestBuildFile {
* @param target target to run
* @param cause information string to reader of report
*/
- public void expectBuildException(String target, String cause) {
+ void expectBuildException(String target, String cause) {
expectSpecificBuildException(target, cause, null);
}
/**
* Assert that the given substring is in the log messages.
*/
- public void assertLogContaining(String substring) {
+ void assertLogContaining(String substring) {
assertContains(getLog(), substring);
}
/**
* Assert that the given substring is not in the log messages.
*/
- public void assertLogNotContaining(String substring) {
+ void assertLogNotContaining(String substring) {
assertNotContained(getLog(), substring);
}
@@ -133,7 +133,7 @@ public class TestBuildFile {
*
* @param targetName target to run
*/
- public void executeTarget(String targetName) {
+ void executeTarget(String targetName) {
PrintStream sysOut = System.out;
PrintStream sysErr = System.err;
try {
@@ -159,7 +159,7 @@ public class TestBuildFile {
* @param msg the message value of the build exception we are waiting
* for set to null for any build exception to be valid
*/
- public void expectSpecificBuildException(String target, String cause, String msg) {
+ void expectSpecificBuildException(String target, String cause, String msg) {
try {
executeTarget(target);
} catch (org.apache.tools.ant.BuildException ex) {
Modified: poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntPrecision.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntPrecision.java?rev=1885319&r1=1885318&r2=1885319&view=diff
==============================================================================
--- poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntPrecision.java (original)
+++ poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntPrecision.java Sat Jan 9 20:25:15 2021
@@ -28,12 +28,12 @@ public class TestExcelAntPrecision {
private ExcelAntPrecision fixture ;
@BeforeEach
- public void setUp() {
+ void setUp() {
fixture = new ExcelAntPrecision() ;
}
@AfterEach
- public void tearDown() {
+ void tearDown() {
fixture = null ;
}
Modified: poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSet.java?rev=1885319&r1=1885318&r2=1885319&view=diff
==============================================================================
--- poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSet.java (original)
+++ poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSet.java Sat Jan 9 20:25:15 2021
@@ -36,12 +36,12 @@ public class TestExcelAntSet {
TestBuildFile.getDataDir() + "/spreadsheet/mortgage-calculation.xls" ;
@BeforeEach
- public void setUp() {
+ void setUp() {
fixture = new ExcelAntSetDoubleCell() ;
}
@AfterEach
- public void tearDown() {
+ void tearDown() {
fixture = null ;
}
Modified: poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSetDoubleCell.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSetDoubleCell.java?rev=1885319&r1=1885318&r2=1885319&view=diff
==============================================================================
--- poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSetDoubleCell.java (original)
+++ poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntSetDoubleCell.java Sat Jan 9 20:25:15 2021
@@ -35,14 +35,14 @@ public class TestExcelAntSetDoubleCell {
TestBuildFile.getDataDir() + "/spreadsheet/mortgage-calculation.xls" ;
@BeforeEach
- public void setUp() {
+ void setUp() {
fixture = new ExcelAntSetDoubleCell() ;
util = ExcelAntWorkbookUtilFactory.getInstance(mortgageCalculatorFileName ) ;
fixture.setWorkbookUtil( util ) ;
}
@AfterEach
- public void tearDown() {
+ void tearDown() {
fixture = null ;
}
Modified: poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntUserDefinedFunction.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntUserDefinedFunction.java?rev=1885319&r1=1885318&r2=1885319&view=diff
==============================================================================
--- poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntUserDefinedFunction.java (original)
+++ poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/TestExcelAntUserDefinedFunction.java Sat Jan 9 20:25:15 2021
@@ -27,7 +27,7 @@ public class TestExcelAntUserDefinedFunc
private ExcelAntUserDefinedFunctionTestHelper fixture ;
@BeforeEach
- public void setUp() {
+ void setUp() {
fixture = new ExcelAntUserDefinedFunctionTestHelper() ;
}
Modified: poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java?rev=1885319&r1=1885318&r2=1885319&view=diff
==============================================================================
--- poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java (original)
+++ poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntEvaluationResult.java Sat Jan 9 20:25:15 2021
@@ -34,7 +34,7 @@ public class TestExcelAntEvaluationResul
private String cellId = "testCell!$F$1";
@BeforeEach
- public void setUp() {
+ void setUp() {
fixture = new ExcelAntEvaluationResult(completedWithError,
passed,
retValue,
@@ -44,7 +44,7 @@ public class TestExcelAntEvaluationResul
}
@AfterEach
- public void tearDown() {
+ void tearDown() {
fixture = null;
}
Modified: poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtil.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtil.java?rev=1885319&r1=1885318&r2=1885319&view=diff
==============================================================================
--- poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtil.java (original)
+++ poi/trunk/src/excelant/testcases/org/apache/poi/ss/excelant/util/TestExcelAntWorkbookUtil.java Sat Jan 9 20:25:15 2021
@@ -49,7 +49,7 @@ public class TestExcelAntWorkbookUtil {
@AfterEach
- public void tearDown() {
+ void tearDown() {
fixture = null ;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org