[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #512: Extend RewriteManifests with a way to add/delete manifests

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #512: Extend RewriteManifests with a way to add/delete manifests
URL: https://github.com/apache/incubator-iceberg/pull/512#discussion_r344165008
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/RewriteManifests.java
 ##########
 @@ -49,9 +51,35 @@
    * that do not match the predicate are kept as-is. If this is not called and no predicate is set, then
    * all manifests will be rewritten.
    *
+   * Note that either clusterBy/rewriteIf should be used or deleteManifest/addManifest, not both.
 
 Review comment:
   I made both of them work at the same time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org