[jira] [Resolved] (ARROW-13315) [R] Wrap r_task_group includes with ARROW_R_WITH_ARROW checking

["Neal Richardson (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARROW-13315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Neal Richardson resolved ARROW-13315.
-------------------------------------
    Resolution: Fixed

Issue resolved by pull request 10707
[https://github.com/apache/arrow/pull/10707]

> [R] Wrap r_task_group includes with ARROW_R_WITH_ARROW checking
> ---------------------------------------------------------------
>
>                 Key: ARROW-13315
>                 URL: https://issues.apache.org/jira/browse/ARROW-13315
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: R
>            Reporter: Jonathan Keane
>            Assignee: Jonathan Keane
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 5.0.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Need to wrap the includes with
> {code}
> #if defined(ARROW_R_WITH_ARROW)
> ...
> #endif
> {code}
> at https://github.com/apache/arrow/blob/master/r/src/r_task_group.h#L20-L21
> {code}
> * installing *source* package ‘arrow’ ...
> ** using staged installation
> *** Proceeding without C++ dependencies
> ------------------------- NOTE ---------------------------
> See https://arrow.apache.org/docs/r/articles/install.html
> for help installing Arrow C++ libraries
> ---------------------------------------------------------
> ** libs
> g++ -std=gnu++11 -I"/usr/share/R/include" -DNDEBUG  -I'/usr/local/lib/R/site-library/cpp11/include'    -fpic  -g -O2 -fdebug-prefix-map=/build/r-base-tbZjLv/r-base-4.1.0=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -Wall -pedantic -c RTasks.cpp -o RTasks.o
> g++ -std=gnu++11 -I"/usr/share/R/include" -DNDEBUG  -I'/usr/local/lib/R/site-library/cpp11/include'    -fpic  -g -O2 -fdebug-prefix-map=/build/r-base-tbZjLv/r-base-4.1.0=. -fstack-protector-strong -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g  -Wall -pedantic -c altrep.cpp -o altrep.o
> In file included from RTasks.cpp:18:
> ./r_task_group.h:20:10: fatal error: arrow/util/parallel.h: No such file or directory
>    20 | #include <arrow/util/parallel.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make: *** [/usr/lib/R/etc/Makeconf:177: RTasks.o] Error 1
> make: *** Waiting for unfinished jobs....
> ERROR: compilation failed for package ‘arrow’
> * removing ‘/tmp/RtmpQLy29Z/Rinst325b11ebc1/arrow’
> {code}
> And also add a CI job that checks this



--
This message was sent by Atlassian Jira
(v8.3.4#803005)