[GitHub] [doris] 924060929 commented on a diff in pull request #11027: [refactor] rename GroupExpression.getParent() to getOwnerGroup()

[GitBox <gi...@apache.org>]

924060929 commented on code in PR #11027:
URL: https://github.com/apache/doris/pull/11027#discussion_r925151810


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java:
##########
@@ -180,8 +180,8 @@ private void mergeGroup(Group source, Group destination) {
                 }
             }
             if (groupExpressions.containsKey(groupExpression)) {
-                // TODO: need to merge group recursively
-                groupExpression.getParent().removeGroupExpression(groupExpression);
+                GroupExpression that = groupExpressions.get(groupExpression);
+                mergeGroup(groupExpression.getOwnerGroup(), that.getOwnerGroup());

Review Comment:
   we should add some ut for merge group recursively



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org