[GitHub] [spark] cloud-fan commented on a diff in pull request #41893: [SPARK-44335][SQL] SQL parser should have a SQLConf parameter instead of relying on the …

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #41893:
URL: https://github.com/apache/spark/pull/41893#discussion_r1256375805


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/CatalystSqlParser.scala:
##########
@@ -16,11 +16,13 @@
  */
 package org.apache.spark.sql.catalyst.parser
 
+import org.apache.spark.sql.internal.SQLConf
+
 /**
  * Concrete SQL parser for Catalyst-only SQL statements.
  */
 class CatalystSqlParser extends AbstractSqlParser {

Review Comment:
   I checked all the caller side, it's not test only, but is only used from simple tasks like parsing table schema or table identifier, which doesn't need SQLConf at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org