[GitHub] [fineract] bharathcgowda commented on pull request #1562: Fix - use expected disbursement for ideal disbursement to fix wrong interest

[GitBox <gi...@apache.org>]

bharathcgowda commented on pull request #1562:
URL: https://github.com/apache/fineract/pull/1562#issuecomment-775876714


   @eitanfr
   Just wanted to mention the functional scenarios again here
   
   Scenario 1
   when "**interest calculation period**" is set to "**daily**" then interest has to calculate from the **Disbursement date**
   
   Scenario 2
   when "**interest calculation period**" is set to "**same as repayment**" and  "Calculate interest for exact days in partial period" checkbox is **selected** then interest has to calculate from the **Disbursement date**
   
   Scenario 3
   when "**interest calculation period**" is set to "**same as repayment**" and  "Calculate interest for exact days in partial period" checkbox is **not selected** then interest has to calculate for that month.
   
   As long as this fix doesn't break these 3 scenarios, it should be fine. 
   
   Also, I would suggest a thorough test with different configurations before making any changes to the interest calculation functionality.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org