You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/10 21:54:21 UTC
[jira] [Commented] (BEAM-243) Remove DirectPipelineRunner and keep
only the InProcessPipelineRunner
[ https://issues.apache.org/jira/browse/BEAM-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325339#comment-15325339 ]
ASF GitHub Bot commented on BEAM-243:
-------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/446
[BEAM-243][BEAM-22] Change the Default PipelineRunner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Select the InProcessRunner if it is on the classpath, and throw an
exception otherwise.
Update tests to be more explicit about their behavior. Move some tests
to more appropriate locations, and other minor fixes.
After submission, running Core SDK tests within an IDE will fail without
additional configuration. All other tests should generally continue to
pass in all cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam change_default_runner
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/446.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #446
----
commit d491e37b2f3cb0b76320f3509d7ec990827c00ec
Author: Thomas Groh <tg...@google.com>
Date: 2016-05-18T23:56:06Z
Update the Default Pipeline Runner
Select the InProcessRunner if it is on the classpath, and throw an
exception otherwise.
commit de49d032730dd21691e6e4358fdcfef249aef46f
Author: Thomas Groh <tg...@google.com>
Date: 2016-06-10T21:36:42Z
Update Pipeline Execution Style in WindowedWordCountTest
This sets the runner a Pipeline creation time rather than sending a
(potentially rewritten) pipeline to a new runner instance.
commit a8a33b19933326c28522dee530974c96d4aef0cb
Author: Thomas Groh <tg...@google.com>
Date: 2016-06-10T21:38:36Z
Update Direct Module tests to explicitly set Pipeline
commit f73bd73caa5e8222946cfc20491fd2806edd1d2b
Author: Thomas Groh <tg...@google.com>
Date: 2016-06-10T21:41:06Z
Use TestPipeline#testingPipelineOptions in IO Tests
commit f2fb59c65119d5da56df5dd4e64fa1873c6ccbbb
Author: Thomas Groh <tg...@google.com>
Date: 2016-06-10T21:43:10Z
Move GcsUtil TextIO Tests to TextIOTest
These tests are not a test of the DataflowRunner, nor any
DataflowRunner specific behavior, so they should be part of TextIOTest
commit 89fa701406409474404095c2577d077514a6daa8
Author: Thomas Groh <tg...@google.com>
Date: 2016-06-10T21:45:58Z
Set Runner in DataflowRunner Tests
Otherwise the Default Runner is used, which may be unavailable.
commit d7e3667b67d138d981f7a9d6938b0fd2a283e3ac
Author: Thomas Groh <tg...@google.com>
Date: 2016-06-10T21:47:53Z
Increase Visibility of Flink Test PipelineOptions
This fixes an issue where the package-private nature would cause an
exception
----
> Remove DirectPipelineRunner and keep only the InProcessPipelineRunner
> ---------------------------------------------------------------------
>
> Key: BEAM-243
> URL: https://issues.apache.org/jira/browse/BEAM-243
> Project: Beam
> Issue Type: Task
> Components: runner-direct
> Reporter: Jean-Baptiste Onofré
> Assignee: Thomas Groh
>
> We have two runners for local JVM/process: the "old" DirectPipelineRunner and the "new" InProcessPipelineRunner.
> They have different feature (for instance the DirectPipelineRunner doesn't support Unbounded PCollection, whereas InProcessPipelineRunner does).
> To avoid confusion, we could remove the "old" DirectPipelineRunner.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)