You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by David James <ja...@gmail.com> on 2005/06/08 17:12:14 UTC
Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)
On 6/7/05, David James <ja...@gmail.com> wrote:
> This patch updates Jani Averbach's test script so that it can send
> automated e-mails to svn-breakage for the Ruby bindings. I also fix a
> small bug in the Ruby tests so that they will run in a VPATH setup
> (Jani's script uses a VPATH setup by default).
>
> Currently the Ruby bindings do not pass tests ( see
> http://svn.haxx.se/dev/archive-2005-06/0215.shtml ).
>
> * tools/test-scripts/svntest/svntest-bindings.sh:
> (Ruby): Test the ruby compile, install, and test targets if
> TEST_BINDINGS_SWIG_RUBY=yes
>
> * tools/test-scripts/svntest/svntest-config.sh:
> (Ruby): Add in TEST_BINDINGS_SWIG_RUBY variable to allow users
> to configure whether they want to run the Ruby tests.
>
> * Makefile.in:
> (check-swig-rb): Switch check-swig-rb to look in the source dir
> instead of the build dir for the test scripts, in case we are
> running in a VPATH setup.
Oops. Fixed a minor typo. Version 2 of the patch is attached.
Cheers,
David
--
http://www.cs.toronto.edu/~james
Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)
Posted by David James <ja...@gmail.com>.
On 6/19/05, Jani Averbach <ja...@jaa.iki.fi> wrote:
> I committed slightly modified version of svntest part of the patch\
> (r15111). I have one comment:
> [...]
> So, to put it short, don't credit me in the patch log as the owner of
> svntest. =)
Thanks for the feedback! And thanks for all your help getting the
tests working :)
Cheers,
David
--
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)
Posted by Jani Averbach <ja...@jaa.iki.fi>.
Hi James,
I committed slightly modified version of svntest part of the patch
(r15111). I have one comment:
On 2005-06-08 13:12-0400, David James wrote:
> On 6/7/05, David James <ja...@gmail.com> wrote:
> > This patch updates Jani Averbach's test script so that it can send
It isn't my test script (Branko has done a lion's share of the test
script), and even if it was done by me, nobody owns subversion
component (in theory). This is one reason why there isn't an author
in the file headers. Search HACKING for full explanation:
"We have a tradition of not marking files with the names of individual
authors..."
So, to put it short, don't credit me in the patch log as the owner of
svntest. =)
Thanks for the patch!
BR, Jani
--
Jani Averbach
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)
Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi,
# I want David to remove Replay-To header.
In <df...@mail.gmail.com>
"Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)" on Wed, 8 Jun 2005 13:12:14 -0400,
David James <ja...@gmail.com> wrote:
> > Currently the Ruby bindings do not pass tests ( see
> > http://svn.haxx.se/dev/archive-2005-06/0215.shtml ).
> >
> > * tools/test-scripts/svntest/svntest-bindings.sh:
> > (Ruby): Test the ruby compile, install, and test targets if
> > TEST_BINDINGS_SWIG_RUBY=yes
> >
> > * tools/test-scripts/svntest/svntest-config.sh:
> > (Ruby): Add in TEST_BINDINGS_SWIG_RUBY variable to allow users
> > to configure whether they want to run the Ruby tests.
> >
> > * Makefile.in:
> > (check-swig-rb): Switch check-swig-rb to look in the source dir
> > instead of the build dir for the test scripts, in case we are
> > running in a VPATH setup.
> Oops. Fixed a minor typo. Version 2 of the patch is attached.
Sorry, I can't make judgements whether the patch is good or
not.
# I think the following diff is not necessary.
# - cd $(SWIG_RB_DIR); $(RUBY) test/run-test.rb
# + cd $(SWIG_RB_DIR); $(RUBY) $(SWIG_RB_TEST_SRCDIR)/run-test.rb
Could you wait someone makes judgments the patch?
--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)
Posted by David James <ja...@gmail.com>.
On 6/9/05, Kouhei Sutou <ko...@cozmixng.org> wrote:
> I see.
>
> Then I want to do the following.
>
> +SWIG_RB_SRCDIR = $(abs_srcdir)/subversion/bindings/swig/ruby
>
> - cd $(SWIG_RB_DIR); $(RUBY) test/run-test.rb
> + cd $(SWIG_RB_SRCDIR); $(RUBY) test/run-test.rb
I like your suggestion -- your code looks cleaner.
If I make your suggested change, can we still be sure that
test/run-test.rb will still send its output files (if any) to the
build directory? You are more familiar with the Ruby test code than I
am.
Thanks,
David
--
http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)
Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi,
In <df...@mail.gmail.com>
"Re: [PATCH] Automated emails to svn-breakage for Ruby bindings (v2)" on Thu, 9 Jun 2005 11:40:13 -0400,
David James <ja...@gmail.com> wrote:
> > Sorry, I can't make judgements whether the patch is good or
> > not.
> > # I think the following diff is not necessary.
> > # - cd $(SWIG_RB_DIR); $(RUBY) test/run-test.rb
> > # + cd $(SWIG_RB_DIR); $(RUBY) $(SWIG_RB_TEST_SRCDIR)/run-test.rb
>
> The above patch makes a difference when $(abs_builddir) is not the
> same as $(abs_srcdir). In your original code, you look in
> $(SWIG_RB_DIR)/test for the run-test.rb file. Since
> SWIG_RB_DIR=$(abs_builddir)/subversion/bindings/swig/ruby, this means
> that you are looking in the build directory for the "run-test.rb"
> file. If the build directory is the same as the source directory, then
> this will work.
>
> On the other hand, if the build directory is different from the source
> directory, then run-test.rb will not exist inside
> $(abs_builddir)/subversion/bindings/swig/ruby. So, my patch switches
> the Makefile to look in $(abs_srcdir)/subversion/bindings/swig/ruby
> instead.
I see.
Then I want to do the following.
+SWIG_RB_SRCDIR = $(abs_srcdir)/subversion/bindings/swig/ruby
- cd $(SWIG_RB_DIR); $(RUBY) test/run-test.rb
+ cd $(SWIG_RB_SRCDIR); $(RUBY) test/run-test.rb
--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org