You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mina.apache.org by lg...@apache.org on 2016/02/23 17:38:24 UTC

[4/8] mina-sshd git commit: Fixed Maven bundle plugin warnings "Export XXX, has 1, private references [XXX]"

http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/3f69f229/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSessionFactory.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSessionFactory.java b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSessionFactory.java
new file mode 100644
index 0000000..b192b89
--- /dev/null
+++ b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSessionFactory.java
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sshd.common.session.helpers;
+
+import org.apache.sshd.common.FactoryManager;
+import org.apache.sshd.common.io.IoSession;
+import org.apache.sshd.common.util.ValidateUtils;
+
+/**
+ * An abstract base factory of sessions.
+ *
+ * @param <M> Type of {@link FactoryManager}
+ * @param <S> Type of {@link AbstractSession}
+ * @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
+ */
+public abstract class AbstractSessionFactory<M extends FactoryManager, S extends AbstractSession> extends AbstractSessionIoHandler {
+    private final M manager;
+
+    protected AbstractSessionFactory(M manager) {
+        this.manager = ValidateUtils.checkNotNull(manager, "No factory manager instance");
+    }
+
+    public M getFactoryManager() {
+        return manager;
+    }
+
+    @Override
+    protected S createSession(IoSession ioSession) throws Exception {
+        return setupSession(doCreateSession(ioSession));
+    }
+
+    protected abstract S doCreateSession(IoSession ioSession) throws Exception;
+
+    protected S setupSession(S session) throws Exception {
+        return session;
+    }
+}

http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/3f69f229/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSessionIoHandler.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSessionIoHandler.java b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSessionIoHandler.java
new file mode 100644
index 0000000..34f4465
--- /dev/null
+++ b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/AbstractSessionIoHandler.java
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sshd.common.session.helpers;
+
+import org.apache.sshd.common.RuntimeSshException;
+import org.apache.sshd.common.io.IoHandler;
+import org.apache.sshd.common.io.IoSession;
+import org.apache.sshd.common.util.Readable;
+import org.apache.sshd.common.util.ValidateUtils;
+import org.apache.sshd.common.util.logging.AbstractLoggingBean;
+
+/**
+ * TODO Add javadoc
+ *
+ * @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
+ */
+public abstract class AbstractSessionIoHandler extends AbstractLoggingBean implements IoHandler {
+    protected AbstractSessionIoHandler() {
+        super();
+    }
+
+    @Override
+    public void sessionCreated(IoSession ioSession) throws Exception {
+        AbstractSession session = ValidateUtils.checkNotNull(
+                createSession(ioSession), "No session created for %s", ioSession);
+        AbstractSession.attachSession(ioSession, session);
+    }
+
+    @Override
+    public void sessionClosed(IoSession ioSession) throws Exception {
+        AbstractSession session = ValidateUtils.checkNotNull(
+                AbstractSession.getSession(ioSession), "No abstract session to handle closure of %s", ioSession);
+        session.close(true);
+    }
+
+    @Override
+    public void exceptionCaught(IoSession ioSession, Throwable cause) throws Exception {
+        AbstractSession session = AbstractSession.getSession(ioSession, true);
+        if (session != null) {
+            session.exceptionCaught(cause);
+        } else {
+            throw new IllegalStateException("No session available", cause);
+        }
+    }
+
+    @Override
+    public void messageReceived(IoSession ioSession, Readable message) throws Exception {
+        AbstractSession session = ValidateUtils.checkNotNull(
+                AbstractSession.getSession(ioSession), "No abstract session to handle incoming message for %s", ioSession);
+        try {
+            session.messageReceived(message);
+        } catch (Error e) {
+            if (log.isDebugEnabled()) {
+                log.debug("messageReceived({}) failed {} to handle message: {}",
+                          ioSession, e.getClass().getSimpleName(), e.getMessage());
+            }
+
+            if (log.isTraceEnabled()) {
+                log.trace("messageReceived(" + ioSession + ") message handling error details", e);
+            }
+            throw new RuntimeSshException(e);
+        }
+    }
+
+    protected abstract AbstractSession createSession(IoSession ioSession) throws Exception;
+}

http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/3f69f229/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/PendingWriteFuture.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/PendingWriteFuture.java b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/PendingWriteFuture.java
new file mode 100644
index 0000000..7df29c4
--- /dev/null
+++ b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/PendingWriteFuture.java
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sshd.common.session.helpers;
+
+import org.apache.sshd.common.future.SshFutureListener;
+import org.apache.sshd.common.io.AbstractIoWriteFuture;
+import org.apache.sshd.common.io.IoWriteFuture;
+import org.apache.sshd.common.util.ValidateUtils;
+import org.apache.sshd.common.util.buffer.Buffer;
+
+/**
+ * Future holding a packet pending key exchange termination.
+ *
+ * @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
+ */
+public class PendingWriteFuture extends AbstractIoWriteFuture implements SshFutureListener<IoWriteFuture> {
+    private final Buffer buffer;
+
+    public PendingWriteFuture(Buffer buffer) {
+        super(null);
+        this.buffer = ValidateUtils.checkNotNull(buffer, "No buffer provided");
+    }
+
+    public Buffer getBuffer() {
+        return buffer;
+    }
+
+    public void setWritten() {
+        setValue(Boolean.TRUE);
+    }
+
+    public void setException(Throwable cause) {
+        ValidateUtils.checkNotNull(cause, "No cause specified");
+        setValue(cause);
+    }
+
+    @Override
+    public void operationComplete(IoWriteFuture future) {
+        if (future.isWritten()) {
+            setWritten();
+        } else {
+            setException(future.getException());
+        }
+    }
+}
\ No newline at end of file

http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/3f69f229/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/ReservedSessionMessagesHandlerAdapter.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/ReservedSessionMessagesHandlerAdapter.java b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/ReservedSessionMessagesHandlerAdapter.java
new file mode 100644
index 0000000..0e62bb0
--- /dev/null
+++ b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/ReservedSessionMessagesHandlerAdapter.java
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.sshd.common.session.helpers;
+
+import org.apache.sshd.common.session.ReservedSessionMessagesHandler;
+import org.apache.sshd.common.session.Session;
+import org.apache.sshd.common.util.buffer.Buffer;
+import org.apache.sshd.common.util.buffer.BufferUtils;
+import org.apache.sshd.common.util.logging.AbstractLoggingBean;
+
+/**
+ * Delegates the main interface methods to specific ones after having
+ * decoded each message buffer
+ *
+ * @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
+ */
+public class ReservedSessionMessagesHandlerAdapter
+        extends AbstractLoggingBean
+        implements ReservedSessionMessagesHandler {
+    public static final ReservedSessionMessagesHandlerAdapter DEFAULT = new ReservedSessionMessagesHandlerAdapter();
+
+    public ReservedSessionMessagesHandlerAdapter() {
+        super();
+    }
+
+    @Override
+    public void handleIgnoreMessage(Session session, Buffer buffer) throws Exception {
+        handleIgnoreMessage(session, buffer.getBytes(), buffer);
+    }
+
+    public void handleIgnoreMessage(Session session, byte[] data, Buffer buffer) throws Exception {
+        if (log.isDebugEnabled()) {
+            log.debug("handleIgnoreMessage({}) SSH_MSG_IGNORE", session);
+        }
+
+        if (log.isTraceEnabled()) {
+            log.trace("handleIgnoreMessage({}) data: {}", session, BufferUtils.toHex(data));
+        }
+    }
+
+    @Override
+    public void handleDebugMessage(Session session, Buffer buffer) throws Exception {
+        handleDebugMessage(session, buffer.getBoolean(), buffer.getString(), buffer.getString(), buffer);
+    }
+
+    public void handleDebugMessage(Session session, boolean display, String msg, String lang, Buffer buffer) throws Exception {
+        if (log.isDebugEnabled()) {
+            log.debug("handleDebugMessage({}) SSH_MSG_DEBUG (display={}) [lang={}] '{}'",
+                      session, display, lang, msg);
+        }
+    }
+}

http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/3f69f229/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/SessionTimeoutListener.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/SessionTimeoutListener.java b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/SessionTimeoutListener.java
new file mode 100644
index 0000000..b1d95fa
--- /dev/null
+++ b/sshd-core/src/main/java/org/apache/sshd/common/session/helpers/SessionTimeoutListener.java
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sshd.common.session.helpers;
+
+import java.util.Set;
+import java.util.concurrent.CopyOnWriteArraySet;
+
+import org.apache.sshd.common.session.Session;
+import org.apache.sshd.common.session.SessionListener;
+import org.apache.sshd.common.util.logging.AbstractLoggingBean;
+
+/**
+ * Task that iterates over all currently open {@link AbstractSession}s and checks each of them for timeouts. If
+ * the {@link AbstractSession} has timed out (either auth or idle timeout), the session will be disconnected.
+ *
+ * @see org.apache.sshd.common.session.helpers.AbstractSession#checkForTimeouts()
+ */
+public class SessionTimeoutListener extends AbstractLoggingBean implements SessionListener, Runnable {
+    private final Set<AbstractSession> sessions = new CopyOnWriteArraySet<AbstractSession>();
+
+    public SessionTimeoutListener() {
+        super();
+    }
+
+    @Override
+    public void sessionCreated(Session session) {
+        if ((session instanceof AbstractSession) && ((session.getAuthTimeout() > 0L) || (session.getIdleTimeout() > 0L))) {
+            sessions.add((AbstractSession) session);
+            log.debug("sessionCreated({}) tracking", session);
+        } else {
+            log.trace("sessionCreated({}) not tracked", session);
+        }
+    }
+
+    @Override
+    public void sessionEvent(Session session, Event event) {
+        // ignored
+    }
+
+    @Override
+    public void sessionException(Session session, Throwable t) {
+        if (log.isDebugEnabled()) {
+            log.debug("sessionException({}) {}: {}", session, t.getClass().getSimpleName(), t.getMessage());
+        }
+        if (log.isTraceEnabled()) {
+            log.trace("sessionException(" + session + ") details", t);
+        }
+        sessionClosed(session);
+    }
+
+    @Override
+    public void sessionClosed(Session s) {
+        if (sessions.remove(s)) {
+            log.debug("sessionClosed({}) un-tracked", s);
+        } else {
+            log.trace("sessionClosed({}) not tracked", s);
+        }
+    }
+
+    @Override
+    public void run() {
+        for (AbstractSession session : sessions) {
+            try {
+                session.checkForTimeouts();
+            } catch (Exception e) {
+                log.warn(e.getClass().getSimpleName() + " while checking session=" + session + " timeouts: " + e.getMessage(), e);
+            }
+        }
+    }
+}

http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/3f69f229/sshd-core/src/main/java/org/apache/sshd/common/session/impl/AbstractConnectionService.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/session/impl/AbstractConnectionService.java b/sshd-core/src/main/java/org/apache/sshd/common/session/impl/AbstractConnectionService.java
deleted file mode 100644
index 83d023c..0000000
--- a/sshd-core/src/main/java/org/apache/sshd/common/session/impl/AbstractConnectionService.java
+++ /dev/null
@@ -1,664 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.sshd.common.session.impl;
-
-import java.io.IOException;
-import java.util.Collection;
-import java.util.List;
-import java.util.Map;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.atomic.AtomicBoolean;
-import java.util.concurrent.atomic.AtomicInteger;
-import java.util.concurrent.atomic.AtomicReference;
-
-import org.apache.sshd.agent.common.AgentForwardSupport;
-import org.apache.sshd.agent.common.DefaultAgentForwardSupport;
-import org.apache.sshd.client.channel.AbstractClientChannel;
-import org.apache.sshd.client.future.OpenFuture;
-import org.apache.sshd.common.Closeable;
-import org.apache.sshd.common.FactoryManager;
-import org.apache.sshd.common.NamedFactory;
-import org.apache.sshd.common.PropertyResolverUtils;
-import org.apache.sshd.common.SshConstants;
-import org.apache.sshd.common.SshException;
-import org.apache.sshd.common.channel.Channel;
-import org.apache.sshd.common.channel.ChannelListener;
-import org.apache.sshd.common.channel.OpenChannelException;
-import org.apache.sshd.common.channel.RequestHandler;
-import org.apache.sshd.common.channel.Window;
-import org.apache.sshd.common.forward.TcpipForwarder;
-import org.apache.sshd.common.forward.TcpipForwarderFactory;
-import org.apache.sshd.common.future.SshFutureListener;
-import org.apache.sshd.common.io.AbstractIoWriteFuture;
-import org.apache.sshd.common.io.IoWriteFuture;
-import org.apache.sshd.common.session.ConnectionService;
-import org.apache.sshd.common.session.Session;
-import org.apache.sshd.common.util.GenericUtils;
-import org.apache.sshd.common.util.Int2IntFunction;
-import org.apache.sshd.common.util.ValidateUtils;
-import org.apache.sshd.common.util.buffer.Buffer;
-import org.apache.sshd.common.util.closeable.AbstractInnerCloseable;
-import org.apache.sshd.server.x11.DefaultX11ForwardSupport;
-import org.apache.sshd.server.x11.X11ForwardSupport;
-
-/**
- * Base implementation of ConnectionService.
- *
- * @param <S> Type of {@link AbstractSession} being used
- * @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
- */
-public abstract class AbstractConnectionService<S extends AbstractSession> extends AbstractInnerCloseable implements ConnectionService {
-    /**
-     * Property that can be used to configure max. allowed concurrent active channels
-     *
-     * @see #registerChannel(Channel)
-     */
-    public static final String MAX_CONCURRENT_CHANNELS_PROP = "max-sshd-channels";
-
-    /**
-     * Default value for {@link #MAX_CONCURRENT_CHANNELS_PROP} is none specified
-     */
-    public static final int DEFAULT_MAX_CHANNELS = Integer.MAX_VALUE;
-
-    /**
-     * Default growth factor function used to resize response buffers
-     */
-    public static final Int2IntFunction RESPONSE_BUFFER_GROWTH_FACTOR = Int2IntFunction.Utils.add(Byte.SIZE);
-
-    /**
-     * Map of channels keyed by the identifier
-     */
-    protected final Map<Integer, Channel> channels = new ConcurrentHashMap<>();
-    /**
-     * Next channel identifier
-     */
-    protected final AtomicInteger nextChannelId = new AtomicInteger(0);
-
-    private final AtomicReference<AgentForwardSupport> agentForwardHolder = new AtomicReference<>();
-    private final AtomicReference<X11ForwardSupport> x11ForwardHolder = new AtomicReference<>();
-    private final AtomicReference<TcpipForwarder> tcpipForwarderHolder = new AtomicReference<>();
-    private final AtomicBoolean allowMoreSessions = new AtomicBoolean(true);
-
-    private final S sessionInstance;
-
-    protected AbstractConnectionService(S session) {
-        sessionInstance = ValidateUtils.checkNotNull(session, "No session");
-    }
-
-    public Collection<Channel> getChannels() {
-        return channels.values();
-    }
-
-    @Override
-    public S getSession() {
-        return sessionInstance;
-    }
-
-    @Override
-    public void start() {
-        // do nothing
-    }
-
-    @Override
-    public TcpipForwarder getTcpipForwarder() {
-        TcpipForwarder forwarder;
-        S session = getSession();
-        synchronized (tcpipForwarderHolder) {
-            forwarder = tcpipForwarderHolder.get();
-            if (forwarder != null) {
-                return forwarder;
-            }
-
-            forwarder = ValidateUtils.checkNotNull(createTcpipForwarder(session), "No forwarder created for %s", session);
-            tcpipForwarderHolder.set(forwarder);
-        }
-
-        if (log.isDebugEnabled()) {
-            log.debug("getTcpipForwarder({}) created instance", session);
-        }
-        return forwarder;
-    }
-
-    protected TcpipForwarder createTcpipForwarder(S session) {
-        FactoryManager manager =
-                ValidateUtils.checkNotNull(session.getFactoryManager(), "No factory manager");
-        TcpipForwarderFactory factory =
-                ValidateUtils.checkNotNull(manager.getTcpipForwarderFactory(), "No forwarder factory");
-        return factory.create(this);
-    }
-
-    @Override
-    public X11ForwardSupport getX11ForwardSupport() {
-        X11ForwardSupport x11Support;
-        S session = getSession();
-        synchronized (x11ForwardHolder) {
-            x11Support = x11ForwardHolder.get();
-            if (x11Support != null) {
-                return x11Support;
-            }
-
-            x11Support = ValidateUtils.checkNotNull(createX11ForwardSupport(session), "No X11 forwarder created for %s", session);
-            x11ForwardHolder.set(x11Support);
-        }
-
-        if (log.isDebugEnabled()) {
-            log.debug("getX11ForwardSupport({}) created instance", session);
-        }
-        return x11Support;
-    }
-
-    protected X11ForwardSupport createX11ForwardSupport(S session) {
-        return new DefaultX11ForwardSupport(this);
-    }
-
-    @Override
-    public AgentForwardSupport getAgentForwardSupport() {
-        AgentForwardSupport agentForward;
-        S session = getSession();
-        synchronized (agentForwardHolder) {
-            agentForward = agentForwardHolder.get();
-            if (agentForward != null) {
-                return agentForward;
-            }
-
-            agentForward = ValidateUtils.checkNotNull(createAgentForwardSupport(session), "No agent forward created for %s", session);
-            agentForwardHolder.set(agentForward);
-        }
-
-        if (log.isDebugEnabled()) {
-            log.debug("getAgentForwardSupport({}) created instance", session);
-        }
-        return agentForward;
-    }
-
-    protected AgentForwardSupport createAgentForwardSupport(S session) {
-        return new DefaultAgentForwardSupport(this);
-    }
-
-    @Override
-    protected Closeable getInnerCloseable() {
-        return builder()
-                .sequential(tcpipForwarderHolder.get(), agentForwardHolder.get(), x11ForwardHolder.get())
-                .parallel(channels.values())
-                .build();
-    }
-
-    protected int getNextChannelId() {
-        return nextChannelId.getAndIncrement();
-    }
-
-    @Override
-    public int registerChannel(Channel channel) throws IOException {
-        Session session = getSession();
-        int maxChannels = PropertyResolverUtils.getIntProperty(session, MAX_CONCURRENT_CHANNELS_PROP, DEFAULT_MAX_CHANNELS);
-        int curSize = channels.size();
-        if (curSize > maxChannels) {
-            throw new IllegalStateException("Currently active channels (" + curSize + ") at max.: " + maxChannels);
-        }
-
-        int channelId = getNextChannelId();
-        channel.init(this, session, channelId);
-
-        boolean registered = false;
-        synchronized (lock) {
-            if (!isClosing()) {
-                channels.put(channelId, channel);
-                registered = true;
-            }
-        }
-
-        if (!registered) {
-            handleChannelRegistrationFailure(channel, channelId);
-        }
-
-        if (log.isDebugEnabled()) {
-            log.debug("registerChannel({})[id={}] {}", this, channelId, channel);
-        }
-        return channelId;
-    }
-
-    protected void handleChannelRegistrationFailure(Channel channel, int channelId) throws IOException {
-        RuntimeException reason = new IllegalStateException("Channel id=" + channelId + " not registered because session is being closed: " + this);
-        ChannelListener listener = channel.getChannelListenerProxy();
-        try {
-            listener.channelClosed(channel, reason);
-        } catch (Throwable err) {
-            Throwable ignored = GenericUtils.peelException(err);
-            log.warn("registerChannel({})[{}] failed ({}) to inform of channel closure: {}",
-                     this, channel, ignored.getClass().getSimpleName(), ignored.getMessage());
-            if (log.isDebugEnabled()) {
-                log.debug("registerChannel(" + this + ")[" + channel + "] inform closure failure details", ignored);
-            }
-            if (log.isTraceEnabled()) {
-                Throwable[] suppressed = ignored.getSuppressed();
-                if (GenericUtils.length(suppressed) > 0) {
-                    for (Throwable s : suppressed) {
-                        log.trace("registerChannel(" + this + ")[" + channel + "] suppressed channel closed signalling", s);
-                    }
-                }
-            }
-        }
-
-        throw reason;
-    }
-
-    /**
-     * Remove this channel from the list of managed channels
-     *
-     * @param channel the channel
-     */
-    @Override
-    public void unregisterChannel(Channel channel) {
-        Channel result = channels.remove(channel.getId());
-        if (log.isDebugEnabled()) {
-            log.debug("unregisterChannel({}) result={}", channel, result);
-        }
-    }
-
-    @Override
-    public void process(int cmd, Buffer buffer) throws Exception {
-        switch (cmd) {
-            case SshConstants.SSH_MSG_CHANNEL_OPEN:
-                channelOpen(buffer);
-                break;
-            case SshConstants.SSH_MSG_CHANNEL_OPEN_CONFIRMATION:
-                channelOpenConfirmation(buffer);
-                break;
-            case SshConstants.SSH_MSG_CHANNEL_OPEN_FAILURE:
-                channelOpenFailure(buffer);
-                break;
-            case SshConstants.SSH_MSG_CHANNEL_REQUEST:
-                channelRequest(buffer);
-                break;
-            case SshConstants.SSH_MSG_CHANNEL_DATA:
-                channelData(buffer);
-                break;
-            case SshConstants.SSH_MSG_CHANNEL_EXTENDED_DATA:
-                channelExtendedData(buffer);
-                break;
-            case SshConstants.SSH_MSG_CHANNEL_FAILURE:
-                channelFailure(buffer);
-                break;
-            case SshConstants.SSH_MSG_CHANNEL_SUCCESS:
-                channelSuccess(buffer);
-                break;
-            case SshConstants.SSH_MSG_CHANNEL_WINDOW_ADJUST:
-                channelWindowAdjust(buffer);
-                break;
-            case SshConstants.SSH_MSG_CHANNEL_EOF:
-                channelEof(buffer);
-                break;
-            case SshConstants.SSH_MSG_CHANNEL_CLOSE:
-                channelClose(buffer);
-                break;
-            case SshConstants.SSH_MSG_GLOBAL_REQUEST:
-                globalRequest(buffer);
-                break;
-            case SshConstants.SSH_MSG_REQUEST_SUCCESS:
-                requestSuccess(buffer);
-                break;
-            case SshConstants.SSH_MSG_REQUEST_FAILURE:
-                requestFailure(buffer);
-                break;
-            default:
-                throw new IllegalStateException("Unsupported command: " + SshConstants.getCommandMessageName(cmd));
-        }
-    }
-
-    @Override
-    public boolean isAllowMoreSessions() {
-        return allowMoreSessions.get();
-    }
-
-    @Override
-    public void setAllowMoreSessions(boolean allow) {
-        if (log.isDebugEnabled()) {
-            log.debug("setAllowMoreSessions({}): {}", this, allow);
-        }
-        allowMoreSessions.set(allow);
-    }
-
-    public void channelOpenConfirmation(Buffer buffer) throws IOException {
-        Channel channel = getChannel(buffer);
-        int sender = buffer.getInt();
-        int rwsize = buffer.getInt();
-        int rmpsize = buffer.getInt();
-        if (log.isDebugEnabled()) {
-            log.debug("channelOpenConfirmation({}) SSH_MSG_CHANNEL_OPEN_CONFIRMATION sender={}, window-size={}, packet-size={}",
-                      channel, sender, rwsize, rmpsize);
-        }
-        /*
-         * NOTE: the 'sender' of the SSH_MSG_CHANNEL_OPEN_CONFIRMATION is the
-         * recipient on the client side - see rfc4254 section 5.1:
-         *
-         *      'sender channel' is the channel number allocated by the other side
-         *
-         * in our case, the server
-         */
-        channel.handleOpenSuccess(sender, rwsize, rmpsize, buffer);
-    }
-
-    public void channelOpenFailure(Buffer buffer) throws IOException {
-        AbstractClientChannel channel = (AbstractClientChannel) getChannel(buffer);
-        int id = channel.getId();
-        if (log.isDebugEnabled()) {
-            log.debug("channelOpenFailure({}) Received SSH_MSG_CHANNEL_OPEN_FAILURE", channel);
-        }
-        channels.remove(id);
-        channel.handleOpenFailure(buffer);
-    }
-
-    /**
-     * Process incoming data on a channel
-     *
-     * @param buffer the buffer containing the data
-     * @throws IOException if an error occurs
-     */
-    public void channelData(Buffer buffer) throws IOException {
-        Channel channel = getChannel(buffer);
-        channel.handleData(buffer);
-    }
-
-    /**
-     * Process incoming extended data on a channel
-     *
-     * @param buffer the buffer containing the data
-     * @throws IOException if an error occurs
-     */
-    public void channelExtendedData(Buffer buffer) throws IOException {
-        Channel channel = getChannel(buffer);
-        channel.handleExtendedData(buffer);
-    }
-
-    /**
-     * Process a window adjust packet on a channel
-     *
-     * @param buffer the buffer containing the window adjustment parameters
-     * @throws IOException if an error occurs
-     */
-    public void channelWindowAdjust(Buffer buffer) throws IOException {
-        try {
-            Channel channel = getChannel(buffer);
-            channel.handleWindowAdjust(buffer);
-        } catch (SshException e) {
-            if (log.isDebugEnabled()) {
-                log.debug("channelWindowAdjust {} error: {}", e.getClass().getSimpleName(), e.getMessage());
-            }
-        }
-    }
-
-    /**
-     * Process end of file on a channel
-     *
-     * @param buffer the buffer containing the packet
-     * @throws IOException if an error occurs
-     */
-    public void channelEof(Buffer buffer) throws IOException {
-        Channel channel = getChannel(buffer);
-        channel.handleEof();
-    }
-
-    /**
-     * Close a channel due to a close packet received
-     *
-     * @param buffer the buffer containing the packet
-     * @throws IOException if an error occurs
-     */
-    public void channelClose(Buffer buffer) throws IOException {
-        Channel channel = getChannel(buffer);
-        channel.handleClose();
-    }
-
-    /**
-     * Service a request on a channel
-     *
-     * @param buffer the buffer containing the request
-     * @throws IOException if an error occurs
-     */
-    public void channelRequest(Buffer buffer) throws IOException {
-        Channel channel = getChannel(buffer);
-        channel.handleRequest(buffer);
-    }
-
-    /**
-     * Process a failure on a channel
-     *
-     * @param buffer the buffer containing the packet
-     * @throws IOException if an error occurs
-     */
-    public void channelFailure(Buffer buffer) throws IOException {
-        Channel channel = getChannel(buffer);
-        channel.handleFailure();
-    }
-
-    /**
-     * Process a success on a channel
-     *
-     * @param buffer the buffer containing the packet
-     * @throws IOException if an error occurs
-     */
-    public void channelSuccess(Buffer buffer) throws IOException {
-        Channel channel = getChannel(buffer);
-        channel.handleSuccess();
-    }
-
-    /**
-     * Retrieve the channel designated by the given packet
-     *
-     * @param buffer the incoming packet
-     * @return the target channel
-     * @throws IOException if the channel does not exists
-     */
-    protected Channel getChannel(Buffer buffer) throws IOException {
-        return getChannel(buffer.getInt(), buffer);
-    }
-
-    protected Channel getChannel(int recipient, Buffer buffer) throws IOException {
-        Channel channel = channels.get(recipient);
-        if (channel == null) {
-            byte[] data = buffer.array();
-            int curPos = buffer.rpos();
-            int cmd = (curPos >= 5) ? (data[curPos - 5] & 0xFF) : -1;
-            throw new SshException("Received " + SshConstants.getCommandMessageName(cmd) + " on unknown channel " + recipient);
-        }
-
-        return channel;
-    }
-
-    protected void channelOpen(Buffer buffer) throws Exception {
-        String type = buffer.getString();
-        final int sender = buffer.getInt();
-        final int rwsize = buffer.getInt();
-        final int rmpsize = buffer.getInt();
-        /*
-         * NOTE: the 'sender' is the identifier assigned by the remote side - the server in this case
-         */
-        if (log.isDebugEnabled()) {
-            log.debug("channelOpen({}) SSH_MSG_CHANNEL_OPEN sender={}, type={}, window-size={}, packet-size={}",
-                      this, sender, type, rwsize, rmpsize);
-        }
-
-        if (isClosing()) {
-            // TODO add language tag
-            sendChannelOpenFailure(buffer, sender, SshConstants.SSH_OPEN_CONNECT_FAILED, "Server is shutting down while attempting to open channel type=" + type, "");
-            return;
-        }
-
-        if (!isAllowMoreSessions()) {
-            // TODO add language tag
-            sendChannelOpenFailure(buffer, sender, SshConstants.SSH_OPEN_CONNECT_FAILED, "additional sessions disabled", "");
-            return;
-        }
-
-        final Session session = getSession();
-        FactoryManager manager = ValidateUtils.checkNotNull(session.getFactoryManager(), "No factory manager");
-        final Channel channel = NamedFactory.Utils.create(manager.getChannelFactories(), type);
-        if (channel == null) {
-            // TODO add language tag
-            sendChannelOpenFailure(buffer, sender, SshConstants.SSH_OPEN_UNKNOWN_CHANNEL_TYPE, "Unsupported channel type: " + type, "");
-            return;
-        }
-
-        final int channelId = registerChannel(channel);
-        channel.open(sender, rwsize, rmpsize, buffer).addListener(new SshFutureListener<OpenFuture>() {
-            @Override
-            @SuppressWarnings("synthetic-access")
-            public void operationComplete(OpenFuture future) {
-                try {
-                    if (future.isOpened()) {
-                        Window window = channel.getLocalWindow();
-                        if (log.isDebugEnabled()) {
-                            log.debug("operationComplete({}) send SSH_MSG_CHANNEL_OPEN_CONFIRMATION recipient={}, sender={}, window-size={}, packet-size={}",
-                                      channel, sender, channelId, window.getSize(), window.getPacketSize());
-                        }
-                        Buffer buf = session.createBuffer(SshConstants.SSH_MSG_CHANNEL_OPEN_CONFIRMATION, Integer.SIZE);
-                        buf.putInt(sender); // remote (server side) identifier
-                        buf.putInt(channelId);  // local (client side) identifier
-                        buf.putInt(window.getSize());
-                        buf.putInt(window.getPacketSize());
-                        session.writePacket(buf);
-                    } else {
-                        Throwable exception = future.getException();
-                        if (exception != null) {
-                            String message = exception.getMessage();
-                            int reasonCode = 0;
-                            if (exception instanceof OpenChannelException) {
-                                reasonCode = ((OpenChannelException) exception).getReasonCode();
-                            } else {
-                                message = exception.getClass().getSimpleName() + " while opening channel: " + message;
-                            }
-
-                            Buffer buf = session.createBuffer(SshConstants.SSH_MSG_CHANNEL_OPEN_FAILURE, message.length() + Long.SIZE);
-                            sendChannelOpenFailure(buf, sender, reasonCode, message, "");
-                        }
-                    }
-                } catch (IOException e) {
-                    if (log.isDebugEnabled()) {
-                        log.debug("operationComplete({}) {}: {}",
-                                  AbstractConnectionService.this, e.getClass().getSimpleName(), e.getMessage());
-                    }
-                    session.exceptionCaught(e);
-                }
-            }
-        });
-    }
-
-    protected IoWriteFuture sendChannelOpenFailure(Buffer buffer, int sender, int reasonCode, String message, String lang) throws IOException {
-        if (log.isDebugEnabled()) {
-            log.debug("sendChannelOpenFailure({}) sender={}, reason={}, lang={}, message='{}'",
-                      this, sender, SshConstants.getOpenErrorCodeName(reasonCode), lang, message);
-        }
-
-        Session session = getSession();
-        Buffer buf = session.createBuffer(SshConstants.SSH_MSG_CHANNEL_OPEN_FAILURE,
-                Long.SIZE + GenericUtils.length(message) + GenericUtils.length(lang));
-        buf.putInt(sender);
-        buf.putInt(reasonCode);
-        buf.putString(message);
-        buf.putString(lang);
-        return session.writePacket(buf);
-    }
-
-    /**
-     * Process global requests
-     *
-     * @param buffer The request {@link Buffer}
-     * @throws Exception If failed to process the request
-     */
-    protected void globalRequest(Buffer buffer) throws Exception {
-        String req = buffer.getString();
-        boolean wantReply = buffer.getBoolean();
-        if (log.isDebugEnabled()) {
-            log.debug("globalRequest({}) received SSH_MSG_GLOBAL_REQUEST {} want-reply={}",
-                      this, req, Boolean.valueOf(wantReply));
-        }
-
-        Session session = getSession();
-        FactoryManager manager =
-                ValidateUtils.checkNotNull(session.getFactoryManager(), "No factory manager");
-        List<RequestHandler<ConnectionService>> handlers = manager.getGlobalRequestHandlers();
-        if (GenericUtils.size(handlers) > 0) {
-            for (RequestHandler<ConnectionService> handler : handlers) {
-                RequestHandler.Result result;
-                try {
-                    result = handler.process(this, req, wantReply, buffer);
-                } catch (Throwable e) {
-                    log.warn("globalRequest({})[{}, want-reply={}] failed ({}) to process: {}",
-                             this, req, wantReply, e.getClass().getSimpleName(), e.getMessage());
-                    if (log.isDebugEnabled()) {
-                        log.debug("globalRequest(" + this + ")[" + req + ", want-reply=" + wantReply + "] failure details", e);
-                    }
-                    result = RequestHandler.Result.ReplyFailure;
-                }
-
-                // if Unsupported then check the next handler in line
-                if (RequestHandler.Result.Unsupported.equals(result)) {
-                    if (log.isTraceEnabled()) {
-                        log.trace("globalRequest({}) {}#process({})[want-reply={}] : {}",
-                                  this, handler.getClass().getSimpleName(), req, wantReply, result);
-                    }
-                } else {
-                    sendGlobalResponse(buffer, req, result, wantReply);
-                    return;
-                }
-            }
-        }
-
-        handleUnknownRequest(buffer, req, wantReply);
-    }
-
-    protected void handleUnknownRequest(Buffer buffer, String req, boolean wantReply) throws IOException {
-        log.warn("handleUnknownRequest({}) unknown global request: {}", this, req);
-        sendGlobalResponse(buffer, req, RequestHandler.Result.Unsupported, wantReply);
-    }
-
-    protected IoWriteFuture sendGlobalResponse(Buffer buffer, String req, RequestHandler.Result result, boolean wantReply) throws IOException {
-        if (log.isDebugEnabled()) {
-            log.debug("sendGlobalResponse({})[{}] result={}, want-reply={}", this, req, result, wantReply);
-        }
-
-        if (RequestHandler.Result.Replied.equals(result) || (!wantReply)) {
-            return new AbstractIoWriteFuture(null) {
-                {
-                    setValue(Boolean.TRUE);
-                }
-            };
-        }
-
-        byte cmd = RequestHandler.Result.ReplySuccess.equals(result)
-                 ? SshConstants.SSH_MSG_REQUEST_SUCCESS
-                 : SshConstants.SSH_MSG_REQUEST_FAILURE;
-        Session session = getSession();
-        Buffer rsp = session.createBuffer(cmd, 2);
-        return session.writePacket(rsp);
-    }
-
-    protected void requestSuccess(Buffer buffer) throws Exception {
-        getSession().requestSuccess(buffer);
-    }
-
-    protected void requestFailure(Buffer buffer) throws Exception {
-        getSession().requestFailure(buffer);
-    }
-
-    @Override
-    public String toString() {
-        return getClass().getSimpleName() + "[" + getSession() + "]";
-    }
-}

http://git-wip-us.apache.org/repos/asf/mina-sshd/blob/3f69f229/sshd-core/src/main/java/org/apache/sshd/common/session/impl/AbstractConnectionServiceRequestHandler.java
----------------------------------------------------------------------
diff --git a/sshd-core/src/main/java/org/apache/sshd/common/session/impl/AbstractConnectionServiceRequestHandler.java b/sshd-core/src/main/java/org/apache/sshd/common/session/impl/AbstractConnectionServiceRequestHandler.java
deleted file mode 100644
index 2aac819..0000000
--- a/sshd-core/src/main/java/org/apache/sshd/common/session/impl/AbstractConnectionServiceRequestHandler.java
+++ /dev/null
@@ -1,46 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package org.apache.sshd.common.session.impl;
-
-import org.apache.sshd.common.session.ConnectionService;
-import org.apache.sshd.common.session.ConnectionServiceRequestHandler;
-import org.apache.sshd.common.util.buffer.Buffer;
-import org.apache.sshd.common.util.logging.AbstractLoggingBean;
-
-/**
- * @author <a href="mailto:dev@mina.apache.org">Apache MINA SSHD Project</a>
- */
-public abstract class AbstractConnectionServiceRequestHandler
-        extends AbstractLoggingBean
-        implements ConnectionServiceRequestHandler {
-
-    protected AbstractConnectionServiceRequestHandler() {
-        super();
-    }
-
-    @Override
-    public Result process(ConnectionService connectionService, String request, boolean wantReply, Buffer buffer) throws Exception {
-        if (log.isDebugEnabled()) {
-            log.debug("process({}) request={}, want-reply={}", connectionService, request, wantReply);
-        }
-
-        return Result.Unsupported;
-    }
-}