You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/01/23 05:20:06 UTC
[GitHub] [camel-website] djencks opened a new pull request #763: Main 701 ri tables
djencks opened a new pull request #763:
URL: https://github.com/apache/camel-website/pull/763
This must be merged in coordination with several other PRs.
This sets up some global helper functions for the RI tables and adds the new branches for camel-k 1.8.x,camel-k-runtime 1.11.x, and kamelets 0.7.x releases. As of this PR creation, the vote has gone on for more than 72 hours but has not concluded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on a change in pull request #763: Main 701 ri tables
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #763:
URL: https://github.com/apache/camel-website/pull/763#discussion_r791437390
##########
File path: util/jsonpath-util.js
##########
@@ -105,6 +105,41 @@ module.exports = {
valueAsString: (value) => {
return value === undefined ? '' : `${value}`
},
+
+// Compatibility table support
+ camelRef: (version, docVersion) => (docVersion === 'none') ? version : `xref:${docVersion}@components:ROOT:index.adoc[${version}]`,
+
+ ckRef: (version, docVersion) => (docVersion === 'none') ? version : `xref:${docVersion}@camel-k:ROOT:index.adoc[${version}]`,
+
+ ckcRef: (version, docVersion) => (docVersion === 'none') ? version : `xref:${docVersion}@camel-kafka-connector:ROOT:index.adoc[${version}]`,
+
+ kameletsRef: (version, docVersion) => (docVersion === 'none') ? version : `xref:${docVersion}@camel-kamelets:ROOT:index.adoc[${version}]`,
+
+ camelQuarkusRef: (version, docVersion) => (docVersion === 'none') ? version : `xref:${docVersion}@camel-quarkus:ROOT:index.adoc[${version}]`,
+
+// External dependency links for compatibility tables
+ graalvmRef: (version, docVersion) => `https://www.graalvm.org/${docVersion}/docs/[${version}]`,
+
+ kafkaRef: (version, docVersion) => `https://kafka.apache.org/${docVersion}/documentation.html[${version}]`,
+
+ quarkusRef: (version) => `https://quarkus.io/guides[${version}]`,
+
+ //Sorts next, then versions descending
+ sortCompatibilityItems: (items) => items.sort((t1, t2) => {
+ const v1 = t1['page-component-version']
+ const v2 = t2['page-component-version']
+ if (v1 === v2) return 0
+ if ((v1 === 'next') || !v2) return -1
+ if ((v2 === 'next') || !v1) return 1
+ const v1s = v1.split('.').map((t) => Number(t))
+ const v2s = v2.split('.').map((t) => Number(t))
+ let i
+ for (i = 0; i < v1s.length; i++) {
+ if (i === v2s.length) return -1
+ if (v1s[i] !== v2s[i]) return v2s[i] - v1s[i] // could be a problem with NaN?
Review comment:
If we stick with equal (3) numbers in each version, I don't think so. If this becomes a bit more complicated we could use [semver](https://www.npmjs.com/package/semver), no need now I think, this is straightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] github-actions[bot] commented on pull request #763: Main 701 ri tables
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #763:
URL: https://github.com/apache/camel-website/pull/763#issuecomment-1020405220
🚀 Preview is available at https://pr-763--camel.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] djencks merged pull request #763: Main 701 ri tables
Posted by GitBox <gi...@apache.org>.
djencks merged pull request #763:
URL: https://github.com/apache/camel-website/pull/763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] djencks merged pull request #763: Main 701 ri tables
Posted by GitBox <gi...@apache.org>.
djencks merged pull request #763:
URL: https://github.com/apache/camel-website/pull/763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] djencks commented on pull request #763: Main 701 ri tables
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #763:
URL: https://github.com/apache/camel-website/pull/763#issuecomment-1020337529
This will fill in all those new RI tables.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on a change in pull request #763: Main 701 ri tables
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #763:
URL: https://github.com/apache/camel-website/pull/763#discussion_r791437390
##########
File path: util/jsonpath-util.js
##########
@@ -105,6 +105,41 @@ module.exports = {
valueAsString: (value) => {
return value === undefined ? '' : `${value}`
},
+
+// Compatibility table support
+ camelRef: (version, docVersion) => (docVersion === 'none') ? version : `xref:${docVersion}@components:ROOT:index.adoc[${version}]`,
+
+ ckRef: (version, docVersion) => (docVersion === 'none') ? version : `xref:${docVersion}@camel-k:ROOT:index.adoc[${version}]`,
+
+ ckcRef: (version, docVersion) => (docVersion === 'none') ? version : `xref:${docVersion}@camel-kafka-connector:ROOT:index.adoc[${version}]`,
+
+ kameletsRef: (version, docVersion) => (docVersion === 'none') ? version : `xref:${docVersion}@camel-kamelets:ROOT:index.adoc[${version}]`,
+
+ camelQuarkusRef: (version, docVersion) => (docVersion === 'none') ? version : `xref:${docVersion}@camel-quarkus:ROOT:index.adoc[${version}]`,
+
+// External dependency links for compatibility tables
+ graalvmRef: (version, docVersion) => `https://www.graalvm.org/${docVersion}/docs/[${version}]`,
+
+ kafkaRef: (version, docVersion) => `https://kafka.apache.org/${docVersion}/documentation.html[${version}]`,
+
+ quarkusRef: (version) => `https://quarkus.io/guides[${version}]`,
+
+ //Sorts next, then versions descending
+ sortCompatibilityItems: (items) => items.sort((t1, t2) => {
+ const v1 = t1['page-component-version']
+ const v2 = t2['page-component-version']
+ if (v1 === v2) return 0
+ if ((v1 === 'next') || !v2) return -1
+ if ((v2 === 'next') || !v1) return 1
+ const v1s = v1.split('.').map((t) => Number(t))
+ const v2s = v2.split('.').map((t) => Number(t))
+ let i
+ for (i = 0; i < v1s.length; i++) {
+ if (i === v2s.length) return -1
+ if (v1s[i] !== v2s[i]) return v2s[i] - v1s[i] // could be a problem with NaN?
Review comment:
If we stick with equal (3) numbers in each version, I don't think so. If this becomes a bit more complicated we could use [semver](https://www.npmjs.com/package/semver), no need now I think, this is straightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] github-actions[bot] commented on pull request #763: Main 701 ri tables
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #763:
URL: https://github.com/apache/camel-website/pull/763#issuecomment-1020405220
🚀 Preview is available at https://pr-763--camel.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org