You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ul...@apache.org on 2022/04/20 01:40:06 UTC
[incubator-kyuubi] branch master updated: [KYUUBI #2410] [Improvement] Fix docker-image-tool.sh example version to 1.4.0
This is an automated email from the ASF dual-hosted git repository.
ulyssesyou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git
The following commit(s) were added to refs/heads/master by this push:
new 5f04aa67e [KYUUBI #2410] [Improvement] Fix docker-image-tool.sh example version to 1.4.0
5f04aa67e is described below
commit 5f04aa67ece63d3d51c26aa3c63905f8385b4118
Author: zwangsheng <22...@qq.com>
AuthorDate: Wed Apr 20 09:39:58 2022 +0800
[KYUUBI #2410] [Improvement] Fix docker-image-tool.sh example version to 1.4.0
### _Why are the changes needed?_
`docker-image-tools.sh` should use the version where the script was added as the trial version.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [x] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #2410 from zwangsheng/bug/fix_docker_image_build_usage.
Closes #2410
f32ef8e2 [zwangsheng] fix version
Authored-by: zwangsheng <22...@qq.com>
Signed-off-by: ulysses-you <ul...@apache.org>
---
bin/docker-image-tool.sh | 8 ++++----
docs/deployment/kyuubi_on_kubernetes.md | 8 ++++----
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/bin/docker-image-tool.sh b/bin/docker-image-tool.sh
index 44bdcc5c3..69a77217a 100755
--- a/bin/docker-image-tool.sh
+++ b/bin/docker-image-tool.sh
@@ -208,12 +208,12 @@ Examples:
$0 -r docker.io/myrepo -t v1.4.0 build
$0 -r docker.io/myrepo -t v1.4.0 push
- - Build and push with tag "v3.0.0" and Spark-3.2.1 as base image to docker.io/myrepo
- $0 -r docker.io/myrepo -t v3.0.0 -b BASE_IMAGE=repo/spark:3.2.1 build
- $0 -r docker.io/myrepo -t v3.0.0 push
+ - Build and push with tag "v1.4.0" and Spark-3.2.1 as base image to docker.io/myrepo
+ $0 -r docker.io/myrepo -t v1.4.0 -b BASE_IMAGE=repo/spark:3.2.1 build
+ $0 -r docker.io/myrepo -t v1.4.0 push
- Build and push for multiple archs to docker.io/myrepo
- $0 -r docker.io/myrepo -t v3.0.0 -X build
+ $0 -r docker.io/myrepo -t v1.4.0 -X build
# Note: buildx, which does cross building, needs to do the push during build
# So there is no separate push step with -X
diff --git a/docs/deployment/kyuubi_on_kubernetes.md b/docs/deployment/kyuubi_on_kubernetes.md
index 133d37b42..fece408f3 100644
--- a/docs/deployment/kyuubi_on_kubernetes.md
+++ b/docs/deployment/kyuubi_on_kubernetes.md
@@ -47,12 +47,12 @@ Examples:
$0 -r docker.io/myrepo -t v1.4.0 build
$0 -r docker.io/myrepo -t v1.4.0 push
- - Build and push with tag "v3.0.0" and Spark-3.2.1 as base image to docker.io/myrepo
- $0 -r docker.io/myrepo -t v3.0.0 -b BASE_IMAGE=repo/spark:3.2.1 build
- $0 -r docker.io/myrepo -t v3.0.0 push
+ - Build and push with tag "v1.4.0" and Spark-3.2.1 as base image to docker.io/myrepo
+ $0 -r docker.io/myrepo -t v1.4.0 -b BASE_IMAGE=repo/spark:3.2.1 build
+ $0 -r docker.io/myrepo -t v1.4.0 push
- Build and push for multiple archs to docker.io/myrepo
- $0 -r docker.io/myrepo -t v3.0.0 -X build
+ $0 -r docker.io/myrepo -t v1.4.0 -X build
- Build with Spark placed "/path/spark"
$0 -s /path/spark build