You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/10/19 22:05:55 UTC

[GitHub] [mynewt-artifact] agross-korg commented on a change in pull request #29: image: Add support for section TLV

agross-korg commented on a change in pull request #29:
URL: https://github.com/apache/mynewt-artifact/pull/29#discussion_r508090054



##########
File path: image/image.go
##########
@@ -67,6 +67,7 @@ const (
 	IMAGE_TLV_ENC_EC256 = 0x32
 	IMAGE_TLV_AES_NONCE = 0x50
 	IMAGE_TLV_SECRET_ID = 0x60
+	IMAGE_TLV_SECTION = 0x70

Review comment:
       yeah good points on the TLV numbers.  What should we do for proprietary TLV numbers?  I wonder if we shouldnt set aside some proprietary range.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org