You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/10 13:28:31 UTC
[GitHub] [spark] wangyum opened a new pull request, #36131: [SPARK-38565][SQL] Support Left Semi join in row level runtime filters
wangyum opened a new pull request, #36131:
URL: https://github.com/apache/spark/pull/36131
### What changes were proposed in this pull request?
1. Support Left Semi join in row level runtime filters.
2. Rename `spark.sql.optimizer.runtime.bloomFilter.applicationSideScanSizethreshold` to `spark.sql.optimizer.runtime.bloomFilter.applicationSideScanSizeThreshold`.
### Why are the changes needed?
Improve query performance and make the code easier to maintain.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sigmod commented on a diff in pull request #36131: [SPARK-38565][SQL] Support Left Semi join in row level runtime filters
Posted by GitBox <gi...@apache.org>.
sigmod commented on code in PR #36131:
URL: https://github.com/apache/spark/pull/36131#discussion_r846993544
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -375,7 +375,7 @@ object SQLConf {
.createWithDefaultString("10MB")
val RUNTIME_BLOOM_FILTER_APPLICATION_SIDE_SCAN_SIZE_THRESHOLD =
- buildConf("spark.sql.optimizer.runtime.bloomFilter.applicationSideScanSizethreshold")
+ buildConf("spark.sql.optimizer.runtime.bloomFilter.applicationSideScanSizeThreshold")
Review Comment:
Ack. Thanks, @wangyum!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a diff in pull request #36131: [SPARK-38565][SQL] Support Left Semi join in row level runtime filters
Posted by GitBox <gi...@apache.org>.
wangyum commented on code in PR #36131:
URL: https://github.com/apache/spark/pull/36131#discussion_r846885360
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -375,7 +375,7 @@ object SQLConf {
.createWithDefaultString("10MB")
val RUNTIME_BLOOM_FILTER_APPLICATION_SIDE_SCAN_SIZE_THRESHOLD =
- buildConf("spark.sql.optimizer.runtime.bloomFilter.applicationSideScanSizethreshold")
+ buildConf("spark.sql.optimizer.runtime.bloomFilter.applicationSideScanSizeThreshold")
Review Comment:
cc @sigmod @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] singhpk234 commented on a diff in pull request #36131: [SPARK-38565][SQL] Support Left Semi join in row level runtime filters
Posted by GitBox <gi...@apache.org>.
singhpk234 commented on code in PR #36131:
URL: https://github.com/apache/spark/pull/36131#discussion_r846814797
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -277,11 +266,11 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with PredicateHelper with J
isSimpleExpression(l) && isSimpleExpression(r)) {
val oldLeft = newLeft
val oldRight = newRight
- if (canFilterLeft(joinType) && filteringHasBenefit(left, right, l, hint)) {
+ if (canPruneLeft(joinType) && filteringHasBenefit(left, right, l, hint)) {
newLeft = injectFilter(l, newLeft, r, right)
}
// Did we actually inject on the left? If not, try on the right
- if (newLeft.fastEquals(oldLeft) && canFilterRight(joinType) &&
+ if (newLeft.fastEquals(oldLeft) && canPruneRight(joinType) &&
Review Comment:
[minor] It would be nice if we could add an UT, just for coverage perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #36131: [SPARK-38565][SQL] Support Left Semi join in row level runtime filters
Posted by GitBox <gi...@apache.org>.
wangyum commented on PR #36131:
URL: https://github.com/apache/spark/pull/36131#issuecomment-1094665866
Merged to master and branch-3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #36131: [SPARK-38565][SQL] Support Left Semi join in row level runtime filters
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #36131: [SPARK-38565][SQL] Support Left Semi join in row level runtime filters
URL: https://github.com/apache/spark/pull/36131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] singhpk234 commented on a diff in pull request #36131: [SPARK-38565][SQL] Support Left Semi join in row level runtime filters
Posted by GitBox <gi...@apache.org>.
singhpk234 commented on code in PR #36131:
URL: https://github.com/apache/spark/pull/36131#discussion_r846814797
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -277,11 +266,11 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with PredicateHelper with J
isSimpleExpression(l) && isSimpleExpression(r)) {
val oldLeft = newLeft
val oldRight = newRight
- if (canFilterLeft(joinType) && filteringHasBenefit(left, right, l, hint)) {
+ if (canPruneLeft(joinType) && filteringHasBenefit(left, right, l, hint)) {
newLeft = injectFilter(l, newLeft, r, right)
}
// Did we actually inject on the left? If not, try on the right
- if (newLeft.fastEquals(oldLeft) && canFilterRight(joinType) &&
+ if (newLeft.fastEquals(oldLeft) && canPruneRight(joinType) &&
Review Comment:
[minor] It would be nice if we could add an UT (for left semi), just for coverage perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org