[jira] [Commented] (JOHNZON-18) JsonStreamParserImpl not filling up buffer consistently

["Hendrik Saly (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JOHNZON-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196442#comment-14196442 ] 

Hendrik Saly commented on JOHNZON-18:
-------------------------------------

not sure if this is necessary here and if read(byte[], int, int) really will return 0 if there is still something to read from the stream. This code fragment is performance crucial so lets make sure that we really need to change it. Maybe we can have a look into some stream impls to get an impression.

> JsonStreamParserImpl not filling up buffer consistently
> -------------------------------------------------------
>
>                 Key: JOHNZON-18
>                 URL: https://issues.apache.org/jira/browse/JOHNZON-18
>             Project: Johnzon
>          Issue Type: Bug
>          Components: Core
>            Reporter: Thiago Veronezi
>             Fix For: 0.2-incubating
>
>         Attachments: JsonStreamParserImpl_not_filling_up_buffer_consistently.patch
>
>
> This is related to the issue discussed [here|https://issues.apache.org/jira/browse/JOHNZON-17]. Basically, the "read" method might not read all the bytes at once. We need to make sure to read at least one until we reach the value "-1".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)