You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Christian Lavoie (JIRA)" <ji...@apache.org> on 2010/09/17 02:10:33 UTC
[jira] Created: (THRIFT-901) Allow the bindings to compile without
-fglasgow-exts and with -Wall -Werror
Allow the bindings to compile without -fglasgow-exts and with -Wall -Werror
---------------------------------------------------------------------------
Key: THRIFT-901
URL: https://issues.apache.org/jira/browse/THRIFT-901
Project: Thrift
Issue Type: Improvement
Components: Haskell - Compiler, Haskell - Library
Affects Versions: 0.5
Environment: Mac OS X 10.6, ghc 6.12.3 (haskell platform 2010.2)
Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
Glasgow Haskell Compiler, Version 6.12.3, for Haskell 98, stage 2 booted by GHC version 6.12.2
Reporter: Christian Lavoie
Priority: Minor
Fix For: 0.5
Attachments: thrift-fix-haskell-bindings.patch
This patch makes the bindings compile with pedantic warning levels, and individually declares each required language extension (using -fglasgow-exts is not always desirable, it significantly changes the set of keywords and prevents some hysteri^Whistorical code from compiling).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-901) Allow the bindings to compile without
-fglasgow-exts and with -Wall -Werror
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-901.
--------------------------------
Assignee: Christian Lavoie
Resolution: Fixed
I just committed this. Thanks for the patch, Christian!
> Allow the bindings to compile without -fglasgow-exts and with -Wall -Werror
> ---------------------------------------------------------------------------
>
> Key: THRIFT-901
> URL: https://issues.apache.org/jira/browse/THRIFT-901
> Project: Thrift
> Issue Type: Improvement
> Components: Haskell - Compiler, Haskell - Library
> Affects Versions: 0.5
> Environment: Mac OS X 10.6, ghc 6.12.3 (haskell platform 2010.2)
> Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> Glasgow Haskell Compiler, Version 6.12.3, for Haskell 98, stage 2 booted by GHC version 6.12.2
> Reporter: Christian Lavoie
> Assignee: Christian Lavoie
> Priority: Minor
> Fix For: 0.5
>
> Attachments: thrift-fix-haskell-bindings.patch, v2-thrift-fix-haskell-bindings.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This patch makes the bindings compile with pedantic warning levels, and individually declares each required language extension (using -fglasgow-exts is not always desirable, it significantly changes the set of keywords and prevents some hysteri^Whistorical code from compiling).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-901) Allow the bindings to compile without
-fglasgow-exts and with -Wall -Werror
Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Lavoie updated THRIFT-901:
------------------------------------
Attachment: v2-thrift-fix-haskell-bindings.patch
Better version of the patch (first version is missing a few fixes).
> Allow the bindings to compile without -fglasgow-exts and with -Wall -Werror
> ---------------------------------------------------------------------------
>
> Key: THRIFT-901
> URL: https://issues.apache.org/jira/browse/THRIFT-901
> Project: Thrift
> Issue Type: Improvement
> Components: Haskell - Compiler, Haskell - Library
> Affects Versions: 0.5
> Environment: Mac OS X 10.6, ghc 6.12.3 (haskell platform 2010.2)
> Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> Glasgow Haskell Compiler, Version 6.12.3, for Haskell 98, stage 2 booted by GHC version 6.12.2
> Reporter: Christian Lavoie
> Priority: Minor
> Fix For: 0.5
>
> Attachments: thrift-fix-haskell-bindings.patch, v2-thrift-fix-haskell-bindings.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This patch makes the bindings compile with pedantic warning levels, and individually declares each required language extension (using -fglasgow-exts is not always desirable, it significantly changes the set of keywords and prevents some hysteri^Whistorical code from compiling).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-901) Allow the bindings to compile without
-fglasgow-exts and with -Wall -Werror
Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Lavoie updated THRIFT-901:
------------------------------------
Attachment: thrift-fix-haskell-bindings.patch
> Allow the bindings to compile without -fglasgow-exts and with -Wall -Werror
> ---------------------------------------------------------------------------
>
> Key: THRIFT-901
> URL: https://issues.apache.org/jira/browse/THRIFT-901
> Project: Thrift
> Issue Type: Improvement
> Components: Haskell - Compiler, Haskell - Library
> Affects Versions: 0.5
> Environment: Mac OS X 10.6, ghc 6.12.3 (haskell platform 2010.2)
> Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> Glasgow Haskell Compiler, Version 6.12.3, for Haskell 98, stage 2 booted by GHC version 6.12.2
> Reporter: Christian Lavoie
> Priority: Minor
> Fix For: 0.5
>
> Attachments: thrift-fix-haskell-bindings.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This patch makes the bindings compile with pedantic warning levels, and individually declares each required language extension (using -fglasgow-exts is not always desirable, it significantly changes the set of keywords and prevents some hysteri^Whistorical code from compiling).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-901) Allow the bindings to compile without
-fglasgow-exts and with -Wall -Werror
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury reassigned THRIFT-901:
------------------------------------
Assignee: Christian Lavoie (was: Bryan Duxbury)
OK, I committed this extra bit. Thanks for keeping an eye on it.
> Allow the bindings to compile without -fglasgow-exts and with -Wall -Werror
> ---------------------------------------------------------------------------
>
> Key: THRIFT-901
> URL: https://issues.apache.org/jira/browse/THRIFT-901
> Project: Thrift
> Issue Type: Improvement
> Components: Haskell - Compiler, Haskell - Library
> Affects Versions: 0.5
> Environment: Mac OS X 10.6, ghc 6.12.3 (haskell platform 2010.2)
> Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> Glasgow Haskell Compiler, Version 6.12.3, for Haskell 98, stage 2 booted by GHC version 6.12.2
> Reporter: Christian Lavoie
> Assignee: Christian Lavoie
> Priority: Minor
> Fix For: 0.5
>
> Attachments: p2-thrift-haskell-no-glasgow-exts.patch, thrift-fix-haskell-bindings.patch, v2-thrift-fix-haskell-bindings.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This patch makes the bindings compile with pedantic warning levels, and individually declares each required language extension (using -fglasgow-exts is not always desirable, it significantly changes the set of keywords and prevents some hysteri^Whistorical code from compiling).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-901) Allow the bindings to compile without
-fglasgow-exts and with -Wall -Werror
Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Lavoie updated THRIFT-901:
------------------------------------
Attachment: p2-thrift-haskell-no-glasgow-exts.patch
This hunk seem to have gotten dropped somehow.
> Allow the bindings to compile without -fglasgow-exts and with -Wall -Werror
> ---------------------------------------------------------------------------
>
> Key: THRIFT-901
> URL: https://issues.apache.org/jira/browse/THRIFT-901
> Project: Thrift
> Issue Type: Improvement
> Components: Haskell - Compiler, Haskell - Library
> Affects Versions: 0.5
> Environment: Mac OS X 10.6, ghc 6.12.3 (haskell platform 2010.2)
> Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> Glasgow Haskell Compiler, Version 6.12.3, for Haskell 98, stage 2 booted by GHC version 6.12.2
> Reporter: Christian Lavoie
> Assignee: Christian Lavoie
> Priority: Minor
> Fix For: 0.5
>
> Attachments: p2-thrift-haskell-no-glasgow-exts.patch, thrift-fix-haskell-bindings.patch, v2-thrift-fix-haskell-bindings.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This patch makes the bindings compile with pedantic warning levels, and individually declares each required language extension (using -fglasgow-exts is not always desirable, it significantly changes the set of keywords and prevents some hysteri^Whistorical code from compiling).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (THRIFT-901) Allow the bindings to compile without
-fglasgow-exts and with -Wall -Werror
Posted by "Christian Lavoie (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Lavoie reassigned THRIFT-901:
---------------------------------------
Assignee: Bryan Duxbury (was: Christian Lavoie)
Sorry, I seem to have dropped a hunk of the original patch.
> Allow the bindings to compile without -fglasgow-exts and with -Wall -Werror
> ---------------------------------------------------------------------------
>
> Key: THRIFT-901
> URL: https://issues.apache.org/jira/browse/THRIFT-901
> Project: Thrift
> Issue Type: Improvement
> Components: Haskell - Compiler, Haskell - Library
> Affects Versions: 0.5
> Environment: Mac OS X 10.6, ghc 6.12.3 (haskell platform 2010.2)
> Darwin -- 10.4.0 Darwin Kernel Version 10.4.0: Fri Apr 23 18:28:53 PDT 2010; root:xnu-1504.7.4~1/RELEASE_I386 i386
> Glasgow Haskell Compiler, Version 6.12.3, for Haskell 98, stage 2 booted by GHC version 6.12.2
> Reporter: Christian Lavoie
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.5
>
> Attachments: p2-thrift-haskell-no-glasgow-exts.patch, thrift-fix-haskell-bindings.patch, v2-thrift-fix-haskell-bindings.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This patch makes the bindings compile with pedantic warning levels, and individually declares each required language extension (using -fglasgow-exts is not always desirable, it significantly changes the set of keywords and prevents some hysteri^Whistorical code from compiling).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.