You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/12/11 13:11:00 UTC
[jira] [Commented] (HBASE-25370) Fix flaky test
TestClassFinder#testClassFinderDefaultsToOwnPackage
[ https://issues.apache.org/jira/browse/HBASE-25370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247918#comment-17247918 ]
Hudson commented on HBASE-25370:
--------------------------------
Results for branch master
[build #155 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/155/]: (/) *{color:green}+1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/155/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/155/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/155/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Fix flaky test TestClassFinder#testClassFinderDefaultsToOwnPackage
> -------------------------------------------------------------------
>
> Key: HBASE-25370
> URL: https://issues.apache.org/jira/browse/HBASE-25370
> Project: HBase
> Issue Type: Test
> Components: test
> Reporter: Adam Wang
> Assignee: Adam Wang
> Priority: Major
> Fix For: 3.0.0-alpha-1, 2.2.7, 2.3.4, 2.5.0, 2.4.1
>
>
> The test {{TestClassFinder#testClassFinderDefaultsToOwnPackage}} compares two sets from {{allClassesFinder.findClasses}}. However, the function {{allClassesFinder.findClasses}} does not return the deterministic order result. From code trace, the root cause is at {{ClassFinder.findClassesFromJar}} and {{ClassFinder.findClassesFromFiles}}. They use {{HashSet}} to store {{classes}} and {{listFiles}} to get file array. However, {{HashSet}} and {{listFiles}} do not guarantee that order, and the assertion can fail if the order differs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)