[GitHub] [arrow] nealrichardson commented on a change in pull request #10593: ARROW-13113: [R] use RTasks to manage parallel in converting arrow to R

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #10593:
URL: https://github.com/apache/arrow/pull/10593#discussion_r658044870



##########
File path: r/R/chunked-array.R
##########
@@ -82,7 +82,7 @@ ChunkedArray <- R6Class("ChunkedArray", inherit = ArrowDatum,
     length = function() ChunkedArray__length(self),
     type_id = function() ChunkedArray__type(self)$id,
     chunk = function(i) Array$create(ChunkedArray__chunk(self, i)),
-    as_vector = function() ChunkedArray__as_vector(self),
+    as_vector = function(use_threads = option_use_threads()) ChunkedArray__as_vector(self, use_threads),

Review comment:
       Should this even be a function argument? Since we moved to controlling this with `option_use_threads()`, it seems like the preferred way to govern this behavior is by setting the option.

##########
File path: r/src/r_task_group.h
##########
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+

Review comment:
       I think this needs the if defined ARROW_R_WITH_ARROW wrapping




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org