You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Brett Porter <br...@apache.org> on 2006/06/22 04:59:17 UTC
Re: svn commit: r416184 - /maven/pom/maven/pom.xml
On 22/06/2006 10:27 AM, carlos@apache.org wrote:
> Author: carlos
> Date: Wed Jun 21 17:27:49 2006
> New Revision: 416184
>
> URL: http://svn.apache.org/viewvc?rev=416184&view=rev
> Log:
> Added checkstyle configuration and pmd check for duplications
Won't that fail the build?
Shouldn't the checks be in a profile?
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r416184 - /maven/pom/maven/pom.xml
Posted by Brett Porter <br...@apache.org>.
If it slows down the build, people will turn it off forcably/complain,
etc too.
We can enable the profile for CI and deployment, which might make it
better. WDYT?
However, I don't know if this should be a "deployment failure" type
issue - I'd be happy with daily nags on it.
- Brett
On 23/06/2006 11:42 AM, Carlos Sanchez wrote:
> My (limited) experience tells me that if you don't enforce it you
> don't get it done
>
> If it's in a profile I can deploy it and then continuum will fail and
> somebody will have to chase me and tell me and then I'd have to fix
> it, which means that the turnaround is pretty big.
>
> I just added now the duplicate lines thing but I'd like to add also
> checkstyle and pmd to enforce some common rules.
>
> On 6/23/06, Brett Porter <br...@apache.org> wrote:
>> So, you'll fix all duplications when you change the parent?
>>
>> I still believe this should be in a profile used by CI. The standard
>> build doesn't need to worry about this.
>>
>> - Brett
>>
>> On 23/06/2006 1:18 AM, Carlos Sanchez wrote:
>> > That's the point, don't accept files with duplications. Better enforce
>> > it proactively.
>> >
>> > On 6/22/06, Brett Porter <br...@apache.org> wrote:
>> >> On 22/06/2006 10:27 AM, carlos@apache.org wrote:
>> >> > Author: carlos
>> >> > Date: Wed Jun 21 17:27:49 2006
>> >> > New Revision: 416184
>> >> >
>> >> > URL: http://svn.apache.org/viewvc?rev=416184&view=rev
>> >> > Log:
>> >> > Added checkstyle configuration and pmd check for duplications
>> >>
>> >> Won't that fail the build?
>> >>
>> >> Shouldn't the checks be in a profile?
>> >>
>> >> - Brett
>> >>
>> >> ---------------------------------------------------------------------
>> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> >> For additional commands, e-mail: dev-help@maven.apache.org
>> >>
>> >>
>> >
>> >
>>
>>
>> --
>> Brett Porter <br...@apache.org>
>> Apache Maven - http://maven.apache.org/
>> Better Builds with Maven - http://library.mergere.com/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
--
Brett Porter <br...@apache.org>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r416184 - /maven/pom/maven/pom.xml
Posted by Carlos Sanchez <ca...@apache.org>.
My (limited) experience tells me that if you don't enforce it you
don't get it done
If it's in a profile I can deploy it and then continuum will fail and
somebody will have to chase me and tell me and then I'd have to fix
it, which means that the turnaround is pretty big.
I just added now the duplicate lines thing but I'd like to add also
checkstyle and pmd to enforce some common rules.
On 6/23/06, Brett Porter <br...@apache.org> wrote:
> So, you'll fix all duplications when you change the parent?
>
> I still believe this should be in a profile used by CI. The standard
> build doesn't need to worry about this.
>
> - Brett
>
> On 23/06/2006 1:18 AM, Carlos Sanchez wrote:
> > That's the point, don't accept files with duplications. Better enforce
> > it proactively.
> >
> > On 6/22/06, Brett Porter <br...@apache.org> wrote:
> >> On 22/06/2006 10:27 AM, carlos@apache.org wrote:
> >> > Author: carlos
> >> > Date: Wed Jun 21 17:27:49 2006
> >> > New Revision: 416184
> >> >
> >> > URL: http://svn.apache.org/viewvc?rev=416184&view=rev
> >> > Log:
> >> > Added checkstyle configuration and pmd check for duplications
> >>
> >> Won't that fail the build?
> >>
> >> Shouldn't the checks be in a profile?
> >>
> >> - Brett
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
> >
> >
>
>
> --
> Brett Porter <br...@apache.org>
> Apache Maven - http://maven.apache.org/
> Better Builds with Maven - http://library.mergere.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r416184 - /maven/pom/maven/pom.xml
Posted by Brett Porter <br...@apache.org>.
So, you'll fix all duplications when you change the parent?
I still believe this should be in a profile used by CI. The standard
build doesn't need to worry about this.
- Brett
On 23/06/2006 1:18 AM, Carlos Sanchez wrote:
> That's the point, don't accept files with duplications. Better enforce
> it proactively.
>
> On 6/22/06, Brett Porter <br...@apache.org> wrote:
>> On 22/06/2006 10:27 AM, carlos@apache.org wrote:
>> > Author: carlos
>> > Date: Wed Jun 21 17:27:49 2006
>> > New Revision: 416184
>> >
>> > URL: http://svn.apache.org/viewvc?rev=416184&view=rev
>> > Log:
>> > Added checkstyle configuration and pmd check for duplications
>>
>> Won't that fail the build?
>>
>> Shouldn't the checks be in a profile?
>>
>> - Brett
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
--
Brett Porter <br...@apache.org>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r416184 - /maven/pom/maven/pom.xml
Posted by Carlos Sanchez <ca...@apache.org>.
That's the point, don't accept files with duplications. Better enforce
it proactively.
On 6/22/06, Brett Porter <br...@apache.org> wrote:
> On 22/06/2006 10:27 AM, carlos@apache.org wrote:
> > Author: carlos
> > Date: Wed Jun 21 17:27:49 2006
> > New Revision: 416184
> >
> > URL: http://svn.apache.org/viewvc?rev=416184&view=rev
> > Log:
> > Added checkstyle configuration and pmd check for duplications
>
> Won't that fail the build?
>
> Shouldn't the checks be in a profile?
>
> - Brett
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
--
I could give you my word as a Spaniard.
No good. I've known too many Spaniards.
-- The Princess Bride
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org