You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/10/25 15:49:09 UTC

[GitHub] [beam] AnandInguva opened a new pull request, #23831: Tensorflow object detection example using RunInference

AnandInguva opened a new pull request, #23831:
URL: https://github.com/apache/beam/pull/23831

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1291224183

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yeandy commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

yeandy commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1303625147

   Is there any harm in adding this example? Especially to showcase TF w/ GPUs? 
   
   (Though we don't have to do it for the sake of adding more. I'll leave the decision up to y'all.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] yeandy commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

yeandy commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1303738470

   I agree that the incremental value-add (especially in the short-term) isn't that high. I don't know the details of your bandwidths, so if there are higher priorities, I think it's ok to table this. We can pick this up from the backlog (keep this draft PR or create an issue?) if there's more time in the future, or a new contributor wants to work on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

damccorm commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1303696767

   I don't mind adding it, but I'm not sure that it adds a ton of value given that we now have https://github.com/apache/beam/pull/23456; I think it would take at least a little additional work to get this ready (we'd at least need a test) and I'd probably vote we focus on other things. If either of you feels differently and wants to take it forward, I'm happy to review and don't have a problem adding it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

AnandInguva commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1303610121

   @damccorm Andy started this and this was used to provide benchmarks for NVIDIA and Dataflow blog. What should we do about this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1294216670

   Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
   
   R: @pabloem for label python.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1291224452

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] closed pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

github-actions[bot] closed pull request #23831: Tensorflow object detection example using RunInference
URL: https://github.com/apache/beam/pull/23831


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1378697676

   This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

AnandInguva commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1295083045

   stop reviewer notifications


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1291221687

   [The Workflow run](https://github.com/apache/beam/actions/runs/3323888870) is cancelling this PR. It is an earlier duplicate of 1729654 run.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

damccorm commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1303754451

   Keeping it in draft seems fine to me, its got all the context we'd need to pick it back up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

codecov[bot] commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1293956518

   # [Codecov](https://codecov.io/gh/apache/beam/pull/23831?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#23831](https://codecov.io/gh/apache/beam/pull/23831?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3776806) into [master](https://codecov.io/gh/apache/beam/commit/de8f4ba446d7d1b275e3731d71404615bc459665?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de8f4ba) will **decrease** coverage by `0.15%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #23831      +/-   ##
   ==========================================
   - Coverage   73.91%   73.75%   -0.16%     
   ==========================================
     Files         703      708       +5     
     Lines       95082    95529     +447     
   ==========================================
   + Hits        70278    70457     +179     
   - Misses      23493    23761     +268     
     Partials     1311     1311              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `83.69% <0.00%> (-0.30%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/23831?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../examples/inference/tensorflow\_object\_detection.py](https://codecov.io/gh/apache/beam/pull/23831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZXhhbXBsZXMvaW5mZXJlbmNlL3RlbnNvcmZsb3dfb2JqZWN0X2RldGVjdGlvbi5weQ==) | `0.00% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/typehints/\_\_init\_\_.py](https://codecov.io/gh/apache/beam/pull/23831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL19faW5pdF9fLnB5) | `71.42% <0.00%> (-6.35%)` | :arrow_down: |
   | [...teractive/testing/integration/notebook\_executor.py](https://codecov.io/gh/apache/beam/pull/23831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS90ZXN0aW5nL2ludGVncmF0aW9uL25vdGVib29rX2V4ZWN1dG9yLnB5) | `28.86% <0.00%> (-1.04%)` | :arrow_down: |
   | [...dks/python/apache\_beam/runners/dask/dask\_runner.py](https://codecov.io/gh/apache/beam/pull/23831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXNrL2Rhc2tfcnVubmVyLnB5) | `10.41% <0.00%> (ø)` | |
   | [.../apache\_beam/typehints/arrow\_type\_compatibility.py](https://codecov.io/gh/apache/beam/pull/23831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL2Fycm93X3R5cGVfY29tcGF0aWJpbGl0eS5weQ==) | `83.94% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/runners/dask/overrides.py](https://codecov.io/gh/apache/beam/pull/23831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXNrL292ZXJyaWRlcy5weQ==) | `51.85% <0.00%> (ø)` | |
   | [...on/apache\_beam/runners/dask/transform\_evaluator.py](https://codecov.io/gh/apache/beam/pull/23831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXNrL3RyYW5zZm9ybV9ldmFsdWF0b3IucHk=) | `12.00% <0.00%> (ø)` | |
   | [sdks/python/apache\_beam/typehints/batch.py](https://codecov.io/gh/apache/beam/pull/23831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL2JhdGNoLnB5) | `90.44% <0.00%> (+0.06%)` | :arrow_up: |
   | [sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/23831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=) | `93.43% <0.00%> (+0.38%)` | :arrow_up: |
   | [...apache\_beam/typehints/pandas\_type\_compatibility.py](https://codecov.io/gh/apache/beam/pull/23831/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3BhbmRhc190eXBlX2NvbXBhdGliaWxpdHkucHk=) | `95.79% <0.00%> (+0.84%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1370888548

   This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #23831: Tensorflow object detection example using RunInference

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on PR #23831:
URL: https://github.com/apache/beam/pull/23831#issuecomment-1295205507

   Stopping reviewer notifications for this pull request: requested by reviewer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org