You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Ivan Kelly (JIRA)" <ji...@apache.org> on 2011/06/30 10:52:28 UTC

[jira] [Created] (ZOOKEEPER-1111) JMXEnv uses System.err instead of logging

JMXEnv uses System.err instead of logging
-----------------------------------------

                 Key: ZOOKEEPER-1111
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1111
             Project: ZooKeeper
          Issue Type: Bug
            Reporter: Ivan Kelly
            Assignee: Ivan Kelly


As stated in the title, org.apache.zookeeper.test.JMXEnv uses System.err.println to output traces. This makes for a lot of noise on the console when you run the tests. It has a logging object already, so it should use that instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1111) JMXEnv uses System.err instead of logging

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057710#comment-13057710 ] 

Hadoop QA commented on ZOOKEEPER-1111:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12484744/ZOOKEEPER-1111.diff
  against trunk revision 1140017.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/359//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/359//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/359//console

This message is automatically generated.

> JMXEnv uses System.err instead of logging
> -----------------------------------------
>
>                 Key: ZOOKEEPER-1111
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1111
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1111.diff
>
>
> As stated in the title, org.apache.zookeeper.test.JMXEnv uses System.err.println to output traces. This makes for a lot of noise on the console when you run the tests. It has a logging object already, so it should use that instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1111) JMXEnv uses System.err instead of logging

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068273#comment-13068273 ] 

Hudson commented on ZOOKEEPER-1111:
-----------------------------------

Integrated in ZooKeeper-trunk #1249 (See [https://builds.apache.org/job/ZooKeeper-trunk/1249/])
    ZOOKEEPER-1111. JMXEnv uses System.err instead of logging (Ivan Kelly via phunt)

phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1148553
Files : 
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/JMXEnv.java


> JMXEnv uses System.err instead of logging
> -----------------------------------------
>
>                 Key: ZOOKEEPER-1111
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1111
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1111.diff
>
>
> As stated in the title, org.apache.zookeeper.test.JMXEnv uses System.err.println to output traces. This makes for a lot of noise on the console when you run the tests. It has a logging object already, so it should use that instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1111) JMXEnv uses System.err instead of logging

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062108#comment-13062108 ] 

Hadoop QA commented on ZOOKEEPER-1111:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12484744/ZOOKEEPER-1111.diff
  against trunk revision 1144087.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/386//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/386//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/386//console

This message is automatically generated.

> JMXEnv uses System.err instead of logging
> -----------------------------------------
>
>                 Key: ZOOKEEPER-1111
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1111
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1111.diff
>
>
> As stated in the title, org.apache.zookeeper.test.JMXEnv uses System.err.println to output traces. This makes for a lot of noise on the console when you run the tests. It has a logging object already, so it should use that instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1111) JMXEnv uses System.err instead of logging

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated ZOOKEEPER-1111:
----------------------------------

    Attachment: ZOOKEEPER-1111.diff

Patch is very simple. Simply replaces System.err with LOG.info. 

I neglected to mention that this only really shows up on hedwig, as zookeeper itself uses ant and ant's junit launcher hijacks System.err into the test log file. 

> JMXEnv uses System.err instead of logging
> -----------------------------------------
>
>                 Key: ZOOKEEPER-1111
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1111
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-1111.diff
>
>
> As stated in the title, org.apache.zookeeper.test.JMXEnv uses System.err.println to output traces. This makes for a lot of noise on the console when you run the tests. It has a logging object already, so it should use that instead.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira