You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/04/11 02:07:38 UTC
[GitHub] [arrow] kou opened a new pull request, #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
kou opened a new pull request, #35023:
URL: https://github.com/apache/arrow/pull/35023
### Rationale for this change
LLVM may use Zstandard. For example `llvm@15` in Homebrew uses Zstandard. LLVM finds
Zstandared by itself. So libzstd.dylib may be used even when `ARROW_ZSTD_USE_SHARED` is `OFF`.
### What changes are included in this PR?
This change adjusts Zstandared used by LLVM to reflect `ARROW_ZSTD_USE_SHARED`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1505913947
+1
The Zstandard problem is solved but there is another problem: #35086
The another problem should be handled in another task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1502586568
* Closes: #35018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1502938992
Revision: ad63ab0a5750beda506934d354f18beeb23aaded
Submitted crossbow builds: [ursacomputing/crossbow @ actions-75d7a04a11](https://github.com/ursacomputing/crossbow/branches/all?query=actions-75d7a04a11)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4665701749/jobs/8259407638)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1504820676
Revision: 8214f13aa4fa11798b17d76c92992b3f67e028c6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0b00070430](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0b00070430)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4675892709/jobs/8281528270)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35023:
URL: https://github.com/apache/arrow/pull/35023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1502841721
Revision: 7a2640fdfa23aa054a038cdd3c75af83ca457a16
Submitted crossbow builds: [ursacomputing/crossbow @ actions-730b028f4a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-730b028f4a)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4665069049/jobs/8257999211)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1502935671
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1502651833
Revision: 7035e7d84a9df76129b4988dd83d499912fc648b
Submitted crossbow builds: [ursacomputing/crossbow @ actions-116b05aaca](https://github.com/ursacomputing/crossbow/branches/all?query=actions-116b05aaca)
|Task|Status|
|----|------|
|java-jars|[](https://github.com/ursacomputing/crossbow/actions/runs/4663689610/jobs/8255236496)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1509755364
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/091043217742433b9ba103c7089efc7f...d2a82c27052948e881b579d0b75bea1a/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1504817780
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1502586587
:warning: GitHub issue #35018 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1502838653
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1502650532
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35023: GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35023:
URL: https://github.com/apache/arrow/pull/35023#issuecomment-1509755136
Benchmark runs are scheduled for baseline = c2904b0bf8ca142dacd44bced8510b5bea540538 and contender = 0434ab65075ecd1d2ab9245bcd7ec6038934ed29. 0434ab65075ecd1d2ab9245bcd7ec6038934ed29 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d82896cbe91d40a0b7b4079b5924e524...8c3ce0b9c4a946f6a0068ef9f126865e/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/370ec8bd3e9e4fa98d48cfa740e3d31f...6c21252512264f6e83686732dae7b2ab/)
[Finished :arrow_down:15.56% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/091043217742433b9ba103c7089efc7f...d2a82c27052948e881b579d0b75bea1a/)
[Finished :arrow_down:0.22% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/316b33106be24afe87dd9bc292aac521...f418762e96534ba3b5157587108dddea/)
Buildkite builds:
[Finished] [`0434ab65` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2703)
[Failed] [`0434ab65` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2737)
[Finished] [`0434ab65` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2701)
[Finished] [`0434ab65` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2728)
[Finished] [`c2904b0b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2702)
[Failed] [`c2904b0b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2736)
[Finished] [`c2904b0b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2700)
[Finished] [`c2904b0b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2727)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org