You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Kevin A. Burton" <bu...@rojo.com> on 2005/03/24 19:45:26 UTC
Re: [patch?] feedparser (organizing imports)
Matthias Wessendorf wrote:
> Hi Kevin,
>
> sorry for bothering you, but I started looking at sources for
> [feedparser] and saw lot's of "import java.xxx.*"
>
> and also unused importstatements.
>
> Are you interessted in "structuring" them?
I liked the remove unused import statements patch. How did you find
this out? Did you use checkstyle or something?
I'm not sure about the generic import java.xxx.* removal. I prefer this
style as it saves a LOT of time over worrying about which classes to import.
I realize that some IDEs have support for just in time class import but
I use Emacs which doesn't have that fancy feature ;)
Would you be interested in separating the patches? I'd like to accept
the remove unnecessary imports code.
Kevin
--
Use Rojo (RSS/Atom aggregator). Visit http://rojo.com. Ask me for an
invite! Also see irc.freenode.net #rojo if you want to chat.
Rojo is Hiring! - http://www.rojonetworks.com/JobsAtRojo.html
If you're interested in RSS, Weblogs, Social Networking, etc... then you
should work for Rojo! If you recommend someone and we hire them you'll
get a free iPod!
Kevin A. Burton, Location - San Francisco, CA
AIM/YIM - sfburtonator, Web - http://peerfear.org/
GPG fingerprint: 5FB2 F3E2 760E 70A8 6174 D393 E84D 8D04 99F1 4412
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [patch?] feedparser (organizing imports)
Posted by "Kevin A. Burton" <bu...@rojo.com>.
Matthias Wessendorf wrote:
> Hi,
>
>> I liked the remove unused import statements patch. How did you find
>> this out? Did you use checkstyle or something?
>
>
> No. I used a feature from eclipse regarding that.
Cool... goign to have to play with that.
> separating means?
> one patch per clazz or per package ?
Oh... separate it into one patch with removing the unnecessary imports ;)
--
Use Rojo (RSS/Atom aggregator). Visit http://rojo.com. Ask me for an
invite! Also see irc.freenode.net #rojo if you want to chat.
Rojo is Hiring! - http://www.rojonetworks.com/JobsAtRojo.html
If you're interested in RSS, Weblogs, Social Networking, etc... then you
should work for Rojo! If you recommend someone and we hire them you'll
get a free iPod!
Kevin A. Burton, Location - San Francisco, CA
AIM/YIM - sfburtonator, Web - http://peerfear.org/
GPG fingerprint: 5FB2 F3E2 760E 70A8 6174 D393 E84D 8D04 99F1 4412
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [patch?] feedparser (organizing imports)
Posted by Matthias Wessendorf <ma...@matthias-wessendorf.de>.
Hi,
> I liked the remove unused import statements patch. How did you find
> this out? Did you use checkstyle or something?
No. I used a feature from eclipse regarding that.
> I'm not sure about the generic import java.xxx.* removal. I prefer this
> style as it saves a LOT of time over worrying about which classes to
> import.
yes yes :)
> I realize that some IDEs have support for just in time class import but
> I use Emacs which doesn't have that fancy feature ;)
>
> Would you be interested in separating the patches? I'd like to accept
> the remove unnecessary imports code.
separating means?
one patch per clazz or per package ?
-Matthias
> Kevin
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org