You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/01/14 19:54:51 UTC
Review Request 42314: Allow schemes in HDFS URI fetcher plugin to be
configurable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42314/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Allow schemes in HDFS URI fetcher plugin to be configurable.
Diffs
-----
src/uri/fetchers/hadoop.hpp 066568487dd3d219f87d12cd0fc82113d3a2a28e
src/uri/fetchers/hadoop.cpp 69da5b5ad3c4d085d73ffbeca7c146e421b5dbc1
Diff: https://reviews.apache.org/r/42314/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42314: Allow schemes in HDFS URI fetcher plugin to
be configurable.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42314/#review114658
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42314]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 15, 2016, 2:31 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42314/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 2:31 a.m.)
>
>
> Review request for mesos, Adam B and Jie Yu.
>
>
> Bugs: MESOS-4375
> https://issues.apache.org/jira/browse/MESOS-4375
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow schemes in HDFS URI fetcher plugin to be configurable.
>
>
> Diffs
> -----
>
> src/tests/uri_fetcher_tests.cpp ca1710cc852ebfd14dd180a245da67e6c98f148f
> src/uri/fetchers/hadoop.hpp 066568487dd3d219f87d12cd0fc82113d3a2a28e
> src/uri/fetchers/hadoop.cpp 69da5b5ad3c4d085d73ffbeca7c146e421b5dbc1
>
> Diff: https://reviews.apache.org/r/42314/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42314: Allow schemes in HDFS URI fetcher plugin to
be configurable.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42314/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 2:31 a.m.)
Review request for mesos, Adam B and Jie Yu.
Changes
-------
Update test case.
Bugs: MESOS-4375
https://issues.apache.org/jira/browse/MESOS-4375
Repository: mesos
Description
-------
Allow schemes in HDFS URI fetcher plugin to be configurable.
Diffs (updated)
-----
src/tests/uri_fetcher_tests.cpp ca1710cc852ebfd14dd180a245da67e6c98f148f
src/uri/fetchers/hadoop.hpp 066568487dd3d219f87d12cd0fc82113d3a2a28e
src/uri/fetchers/hadoop.cpp 69da5b5ad3c4d085d73ffbeca7c146e421b5dbc1
Diff: https://reviews.apache.org/r/42314/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42314: Allow schemes in HDFS URI fetcher plugin to
be configurable.
Posted by haosdent huang <ha...@gmail.com>.
> On Jan. 14, 2016, 11:35 p.m., Timothy Chen wrote:
> > src/uri/fetchers/hadoop.cpp, line 59
> > <https://reviews.apache.org/r/42314/diff/3/?file=1197029#file1197029line59>
> >
> > This seems unncessary, even if there is duplicate I think we simply just override the entry when we register the scheme.
Yes, but because we define the interface to `virtual std::set<std::string> schemes() = 0;` in `../../include/mesos/uri/fetcher.hpp`. I think pass set here is better.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42314/#review114606
-----------------------------------------------------------
On Jan. 14, 2016, 7:09 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42314/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 7:09 p.m.)
>
>
> Review request for mesos, Adam B and Jie Yu.
>
>
> Bugs: MESOS-4375
> https://issues.apache.org/jira/browse/MESOS-4375
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow schemes in HDFS URI fetcher plugin to be configurable.
>
>
> Diffs
> -----
>
> src/uri/fetchers/hadoop.hpp 066568487dd3d219f87d12cd0fc82113d3a2a28e
> src/uri/fetchers/hadoop.cpp 69da5b5ad3c4d085d73ffbeca7c146e421b5dbc1
>
> Diff: https://reviews.apache.org/r/42314/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42314: Allow schemes in HDFS URI fetcher plugin to
be configurable.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42314/#review114606
-----------------------------------------------------------
src/uri/fetchers/hadoop.cpp (line 59)
<https://reviews.apache.org/r/42314/#comment175468>
This seems unncessary, even if there is duplicate I think we simply just override the entry when we register the scheme.
- Timothy Chen
On Jan. 14, 2016, 7:09 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42314/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 7:09 p.m.)
>
>
> Review request for mesos, Adam B and Jie Yu.
>
>
> Bugs: MESOS-4375
> https://issues.apache.org/jira/browse/MESOS-4375
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow schemes in HDFS URI fetcher plugin to be configurable.
>
>
> Diffs
> -----
>
> src/uri/fetchers/hadoop.hpp 066568487dd3d219f87d12cd0fc82113d3a2a28e
> src/uri/fetchers/hadoop.cpp 69da5b5ad3c4d085d73ffbeca7c146e421b5dbc1
>
> Diff: https://reviews.apache.org/r/42314/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 42314: Allow schemes in HDFS URI fetcher plugin to
be configurable.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42314/
-----------------------------------------------------------
(Updated Jan. 14, 2016, 7:09 p.m.)
Review request for mesos, Adam B and Jie Yu.
Changes
-------
remove unused header files.
Bugs: MESOS-4375
https://issues.apache.org/jira/browse/MESOS-4375
Repository: mesos
Description
-------
Allow schemes in HDFS URI fetcher plugin to be configurable.
Diffs (updated)
-----
src/uri/fetchers/hadoop.hpp 066568487dd3d219f87d12cd0fc82113d3a2a28e
src/uri/fetchers/hadoop.cpp 69da5b5ad3c4d085d73ffbeca7c146e421b5dbc1
Diff: https://reviews.apache.org/r/42314/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42314: Allow schemes in HDFS URI fetcher plugin to
be configurable.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42314/
-----------------------------------------------------------
(Updated Jan. 14, 2016, 7:06 p.m.)
Review request for mesos, Adam B and Jie Yu.
Changes
-------
Address @jieyu's comments.
Bugs: MESOS-4375
https://issues.apache.org/jira/browse/MESOS-4375
Repository: mesos
Description
-------
Allow schemes in HDFS URI fetcher plugin to be configurable.
Diffs (updated)
-----
src/uri/fetchers/hadoop.hpp 066568487dd3d219f87d12cd0fc82113d3a2a28e
src/uri/fetchers/hadoop.cpp 69da5b5ad3c4d085d73ffbeca7c146e421b5dbc1
Diff: https://reviews.apache.org/r/42314/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 42314: Allow schemes in HDFS URI fetcher plugin to
be configurable.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42314/
-----------------------------------------------------------
(Updated Jan. 14, 2016, 6:59 p.m.)
Review request for mesos, Adam B and Jie Yu.
Bugs: MESOS-4375
https://issues.apache.org/jira/browse/MESOS-4375
Repository: mesos
Description
-------
Allow schemes in HDFS URI fetcher plugin to be configurable.
Diffs
-----
src/uri/fetchers/hadoop.hpp 066568487dd3d219f87d12cd0fc82113d3a2a28e
src/uri/fetchers/hadoop.cpp 69da5b5ad3c4d085d73ffbeca7c146e421b5dbc1
Diff: https://reviews.apache.org/r/42314/diff/
Testing
-------
Thanks,
haosdent huang