[GitHub] mistercrunch commented on a change in pull request #4183: [datasource editor] click checkbox creates metrics instantly

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4183: [datasource editor] click checkbox creates metrics instantly
URL: https://github.com/apache/incubator-superset/pull/4183#discussion_r160526921
 
 

 ##########
 File path: superset/connectors/sqla/models.py
 ##########
 @@ -155,6 +159,42 @@ def dttm_sql_literal(self, dttm):
                 self.type or '', dttm)
             return s or "'{}'".format(dttm.strftime('%Y-%m-%d %H:%M:%S.%f'))
 
+    def get_metrics(self):
+        metrics = []
+        M = SqlMetric  # noqa
+        quoted = self.column_name
+        if self.sum:
 
 Review comment:
   I didn't want to risk it as metrics may be used in charts and users may create issues. User then have to both uncheck and explicitly delete the metric.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services