You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/03 01:36:32 UTC
[GitHub] graceguo-supercat commented on issue #4922: [WorldMap] Add required
parameter validation
graceguo-supercat commented on issue #4922: [WorldMap] Add required parameter validation
URL: https://github.com/apache/incubator-superset/pull/4922#issuecomment-386170168
yeah, i am thinking about this could be optional parameter.
Here:
[ qry['metrics'] = [
self.form_data['metric'], self.form_data['secondary_metric']]
](https://github.com/Anatoly-vivaki1986/SuperSet/blob/868e5c45fed8e090750dffe88660f3943f373c19/superset/viz.py#L1604)
I don't know what's the best way to fallback a default value? Otherwise it will append None into `metrics` array
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org