You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/09 23:32:18 UTC

[GitHub] [hudi] nsivabalan commented on a change in pull request #3955: [HUDI-2718] ExternalSpillableMap payload size re-estimation throws ArithmeticException

nsivabalan commented on a change in pull request #3955:
URL: https://github.com/apache/hudi/pull/3955#discussion_r746130666



##########
File path: hudi-common/src/test/java/org/apache/hudi/common/util/collection/TestExternalSpillableMap.java
##########
@@ -339,7 +343,41 @@ public void testDataCorrectnessWithoutHoodieMetadata(ExternalSpillableMap.DiskMa
 
   // TODO : come up with a performance eval test for spillableMap
   @Test
-  public void testLargeInsertUpsert() {}
+  public void testLargeInsertUpsert() {
+  }
+
+  @ParameterizedTest
+  @MethodSource("testArguments")
+  public void testPayloadSizeEstimate(ExternalSpillableMap.DiskMapType diskMapType,

Review comment:
       I guess we don't need to do parametrized here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org