You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/08/19 08:49:31 UTC
[kudu-CR] Remove CHECK that undos always exist
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4061
to review the following change.
Change subject: Remove CHECK that undos always exist
......................................................................
Remove CHECK that undos always exist
This is a forward-compatibility patch that would potentially allow a
user to downgrade from a version of Kudu that supports UNDO GC to this
version.
Change-Id: Ia58a7a9e6b13c5e3257ce0de1156977319be3a89
---
M src/kudu/tablet/compaction.cc
1 file changed, 0 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/4061/1
--
To view, visit http://gerrit.cloudera.org:8080/4061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia58a7a9e6b13c5e3257ce0de1156977319be3a89
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Remove CHECK that undos always exist
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Remove CHECK that undos always exist
......................................................................
Patch Set 1:
Also, have you tested that this actually allows for downgrade? ie there's no other code path which will now explode if you try to compact something with no UNDOs?
--
To view, visit http://gerrit.cloudera.org:8080/4061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia58a7a9e6b13c5e3257ce0de1156977319be3a89
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Remove CHECK that undos always exist
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: Remove CHECK that undos always exist
......................................................................
Abandoned
Since 0.10.0 is out the door, I am going to abandon this patch. We can try to revive it if we do a 0.10.1, perhaps.
--
To view, visit http://gerrit.cloudera.org:8080/4061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia58a7a9e6b13c5e3257ce0de1156977319be3a89
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Remove CHECK that undos always exist
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Remove CHECK that undos always exist
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4061/1/src/kudu/tablet/compaction.cc
File src/kudu/tablet/compaction.cc:
Line 795: out->AppendUndoDeltas(dst_row.row_index(), new_undos_head, &index_in_current_drs_);
do you need to now wrap this in an: if (new_undos_head != nullptr)?
--
To view, visit http://gerrit.cloudera.org:8080/4061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia58a7a9e6b13c5e3257ce0de1156977319be3a89
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Remove CHECK that undos always exist
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Remove CHECK that undos always exist
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2993/
--
To view, visit http://gerrit.cloudera.org:8080/4061
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia58a7a9e6b13c5e3257ce0de1156977319be3a89
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No