You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "hartmannathan (via GitHub)" <gi...@apache.org> on 2023/01/22 14:28:36 UTC

[GitHub] [nuttx-apps] hartmannathan commented on a diff in pull request #1492: Enable TMPFS and NSH_QUOTE to get CONFIG_NSH_CMDPARMS working

hartmannathan commented on code in PR #1492:
URL: https://github.com/apache/nuttx-apps/pull/1492#discussion_r1083464226


##########
nshlib/Kconfig:
##########
@@ -127,6 +127,8 @@ config NSH_CMDPARMS
 	bool "Enable commands as parameters"
 	default !DEFAULT_SMALL
 	depends on !DISABLE_MOUNTPOINT
+	select FS_TMPFS
+	select NSH_QUOTE

Review Comment:
   Too bad there isn't a feature in the Kconfig menu to show all features, including those with missing dependent features. By default they would be hidden, but the user could show all features to find out what other possibilities exist. This would require opening a PR with Kconfig-frontends. I think that's [here](https://github.com/uvc-ingenieure/kconfig-frontends) now? (Not sure if that's ahead or behind the one we've used in the past.)
   
   Alternately it would be cool if autogenerated docs from the Kconfigs could show everything and explain the dependencies. We could probably do this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org