You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/08/10 13:22:16 UTC

Review Request 37293: LENS-711 : Allow chain ref columns to have multiple chain destinations

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37293/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-711
    https://issues.apache.org/jira/browse/LENS-711


Repository: lens


Description
-------

Changes include :
- Add ability to specify multiple chain columns
- Add rewriter capability to understand multiple chains for a column
- Rewriter tests added
- End to end test in lens-cli


Diffs
-----

  lens-api/src/main/resources/cube-0.1.xsd e6cb87d 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 9912eef 
  lens-cli/src/test/resources/sample-cube.xml f0eba57 
  lens-cli/src/test/resources/test-detail.xml PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java 742c6a0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 077396e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1d4e7dd 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 7d9183c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 00d92b5 
  lens-examples/src/main/resources/sales-cube.xml 4923aa3 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70bd20d 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6e3afc6 

Diff: https://reviews.apache.org/r/37293/diff/


Testing
-------

Verified examples

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.468s]
[INFO] Lens .............................................. SUCCESS [3.083s]
[INFO] Lens API .......................................... SUCCESS [21.917s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.881s]
[INFO] Lens Cube ......................................... SUCCESS [6:14.198s]
[INFO] Lens DB storage ................................... SUCCESS [20.475s]
[INFO] Lens Query Library ................................ SUCCESS [15.247s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.498s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [39.033s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [15.428s]
[INFO] Lens Server ....................................... SUCCESS [5:41.025s]
[INFO] Lens client ....................................... SUCCESS [37.324s]
[INFO] Lens CLI .......................................... SUCCESS [2:33.561s]
[INFO] Lens Examples ..................................... SUCCESS [9.115s]
[INFO] Lens Distribution ................................. SUCCESS [8.490s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.698s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.995s]
[INFO] Lens Regression ................................... SUCCESS [10.622s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:04.962s
[INFO] Finished at: Mon Aug 10 11:08:50 UTC 2015
[INFO] Final Memory: 204M/2499M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 37293: LENS-711 : Allow chain ref columns to have multiple chain destinations

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37293/#review94887
-----------------------------------------------------------

Ship it!


Please update test results after the last changes.

- Rajat Khandelwal


On Aug. 11, 2015, 12:25 p.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37293/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 12:25 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-711
>     https://issues.apache.org/jira/browse/LENS-711
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include :
> - Add ability to specify multiple chain columns
> - Add rewriter capability to understand multiple chains for a column
> - Rewriter tests added
> - End to end test in lens-cli
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd e6cb87d 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 9912eef 
>   lens-cli/src/test/resources/sample-cube.xml f0eba57 
>   lens-cli/src/test/resources/test-detail.xml PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java f0a0dfe 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8fbfe63 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java 742c6a0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 077396e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1d4e7dd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 7d9183c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 00d92b5 
>   lens-examples/src/main/resources/sales-cube.xml 4923aa3 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70bd20d 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6e3afc6 
> 
> Diff: https://reviews.apache.org/r/37293/diff/
> 
> 
> Testing
> -------
> 
> Verified examples
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.563s]
> [INFO] Lens .............................................. SUCCESS [3.148s]
> [INFO] Lens API .......................................... SUCCESS [22.225s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.040s]
> [INFO] Lens Cube ......................................... SUCCESS [5:05.342s]
> [INFO] Lens DB storage ................................... SUCCESS [19.800s]
> [INFO] Lens Query Library ................................ SUCCESS [15.939s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:52.849s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.485s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.515s]
> [INFO] Lens Server ....................................... SUCCESS [5:39.271s]
> [INFO] Lens client ....................................... SUCCESS [34.686s]
> [INFO] Lens CLI .......................................... SUCCESS [2:38.436s]
> [INFO] Lens Examples ..................................... SUCCESS [8.615s]
> [INFO] Lens Distribution ................................. SUCCESS [8.438s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.479s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.905s]
> [INFO] Lens Regression ................................... SUCCESS [10.500s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:58.156s
> [INFO] Finished at: Tue Aug 11 05:21:11 UTC 2015
> [INFO] Final Memory: 189M/1543M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>


Re: Review Request 37293: LENS-711 : Allow chain ref columns to have multiple chain destinations

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37293/
-----------------------------------------------------------

(Updated Aug. 11, 2015, 6:55 a.m.)


Review request for lens.


Changes
-------

review comments fixed.
mvn clean install passes on lens-cube module.


Bugs: LENS-711
    https://issues.apache.org/jira/browse/LENS-711


Repository: lens


Description
-------

Changes include :
- Add ability to specify multiple chain columns
- Add rewriter capability to understand multiple chains for a column
- Rewriter tests added
- End to end test in lens-cli


Diffs (updated)
-----

  lens-api/src/main/resources/cube-0.1.xsd e6cb87d 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 9912eef 
  lens-cli/src/test/resources/sample-cube.xml f0eba57 
  lens-cli/src/test/resources/test-detail.xml PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java f0a0dfe 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 8fbfe63 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java 742c6a0 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 077396e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1d4e7dd 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 7d9183c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 00d92b5 
  lens-examples/src/main/resources/sales-cube.xml 4923aa3 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70bd20d 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6e3afc6 

Diff: https://reviews.apache.org/r/37293/diff/


Testing
-------

Verified examples

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.563s]
[INFO] Lens .............................................. SUCCESS [3.148s]
[INFO] Lens API .......................................... SUCCESS [22.225s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.040s]
[INFO] Lens Cube ......................................... SUCCESS [5:05.342s]
[INFO] Lens DB storage ................................... SUCCESS [19.800s]
[INFO] Lens Query Library ................................ SUCCESS [15.939s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:52.849s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.485s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [15.515s]
[INFO] Lens Server ....................................... SUCCESS [5:39.271s]
[INFO] Lens client ....................................... SUCCESS [34.686s]
[INFO] Lens CLI .......................................... SUCCESS [2:38.436s]
[INFO] Lens Examples ..................................... SUCCESS [8.615s]
[INFO] Lens Distribution ................................. SUCCESS [8.438s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.479s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.905s]
[INFO] Lens Regression ................................... SUCCESS [10.500s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:58.156s
[INFO] Finished at: Tue Aug 11 05:21:11 UTC 2015
[INFO] Final Memory: 189M/1543M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 37293: LENS-711 : Allow chain ref columns to have multiple chain destinations

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37293/#review94883
-----------------------------------------------------------



lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java (line 1194)
<https://reviews.apache.org/r/37293/#comment149558>

    Should `getFactOrDimtableStorageTableName` take care of doing `toLowerCase()`?


- Rajat Khandelwal


On Aug. 11, 2015, 11:05 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37293/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 11:05 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-711
>     https://issues.apache.org/jira/browse/LENS-711
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include :
> - Add ability to specify multiple chain columns
> - Add rewriter capability to understand multiple chains for a column
> - Rewriter tests added
> - End to end test in lens-cli
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd e6cb87d 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 9912eef 
>   lens-cli/src/test/resources/sample-cube.xml f0eba57 
>   lens-cli/src/test/resources/test-detail.xml PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java f0a0dfe 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java 742c6a0 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 9d5e264 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c82da7b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 077396e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1d4e7dd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 7d9183c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 00d92b5 
>   lens-examples/src/main/resources/sales-cube.xml 4923aa3 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70bd20d 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6e3afc6 
> 
> Diff: https://reviews.apache.org/r/37293/diff/
> 
> 
> Testing
> -------
> 
> Verified examples
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.563s]
> [INFO] Lens .............................................. SUCCESS [3.148s]
> [INFO] Lens API .......................................... SUCCESS [22.225s]
> [INFO] Lens API for server and extensions ................ SUCCESS [21.040s]
> [INFO] Lens Cube ......................................... SUCCESS [5:05.342s]
> [INFO] Lens DB storage ................................... SUCCESS [19.800s]
> [INFO] Lens Query Library ................................ SUCCESS [15.939s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:52.849s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.485s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.515s]
> [INFO] Lens Server ....................................... SUCCESS [5:39.271s]
> [INFO] Lens client ....................................... SUCCESS [34.686s]
> [INFO] Lens CLI .......................................... SUCCESS [2:38.436s]
> [INFO] Lens Examples ..................................... SUCCESS [8.615s]
> [INFO] Lens Distribution ................................. SUCCESS [8.438s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.479s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.905s]
> [INFO] Lens Regression ................................... SUCCESS [10.500s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:58.156s
> [INFO] Finished at: Tue Aug 11 05:21:11 UTC 2015
> [INFO] Final Memory: 189M/1543M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>


Re: Review Request 37293: LENS-711 : Allow chain ref columns to have multiple chain destinations

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37293/
-----------------------------------------------------------

(Updated Aug. 11, 2015, 5:35 a.m.)


Review request for lens.


Bugs: LENS-711
    https://issues.apache.org/jira/browse/LENS-711


Repository: lens


Description
-------

Changes include :
- Add ability to specify multiple chain columns
- Add rewriter capability to understand multiple chains for a column
- Rewriter tests added
- End to end test in lens-cli


Diffs
-----

  lens-api/src/main/resources/cube-0.1.xsd e6cb87d 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 9912eef 
  lens-cli/src/test/resources/sample-cube.xml f0eba57 
  lens-cli/src/test/resources/test-detail.xml PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java f0a0dfe 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java 742c6a0 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 9d5e264 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c82da7b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 077396e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1d4e7dd 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 7d9183c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 00d92b5 
  lens-examples/src/main/resources/sales-cube.xml 4923aa3 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70bd20d 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6e3afc6 

Diff: https://reviews.apache.org/r/37293/diff/


Testing (updated)
-------

Verified examples

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.563s]
[INFO] Lens .............................................. SUCCESS [3.148s]
[INFO] Lens API .......................................... SUCCESS [22.225s]
[INFO] Lens API for server and extensions ................ SUCCESS [21.040s]
[INFO] Lens Cube ......................................... SUCCESS [5:05.342s]
[INFO] Lens DB storage ................................... SUCCESS [19.800s]
[INFO] Lens Query Library ................................ SUCCESS [15.939s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:52.849s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.485s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [15.515s]
[INFO] Lens Server ....................................... SUCCESS [5:39.271s]
[INFO] Lens client ....................................... SUCCESS [34.686s]
[INFO] Lens CLI .......................................... SUCCESS [2:38.436s]
[INFO] Lens Examples ..................................... SUCCESS [8.615s]
[INFO] Lens Distribution ................................. SUCCESS [8.438s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.479s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.905s]
[INFO] Lens Regression ................................... SUCCESS [10.500s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:58.156s
[INFO] Finished at: Tue Aug 11 05:21:11 UTC 2015
[INFO] Final Memory: 189M/1543M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 37293: LENS-711 : Allow chain ref columns to have multiple chain destinations

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37293/
-----------------------------------------------------------

(Updated Aug. 11, 2015, 5:02 a.m.)


Review request for lens.


Changes
-------

Fixed review comment


Bugs: LENS-711
    https://issues.apache.org/jira/browse/LENS-711


Repository: lens


Description
-------

Changes include :
- Add ability to specify multiple chain columns
- Add rewriter capability to understand multiple chains for a column
- Rewriter tests added
- End to end test in lens-cli


Diffs (updated)
-----

  lens-api/src/main/resources/cube-0.1.xsd e6cb87d 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 9912eef 
  lens-cli/src/test/resources/sample-cube.xml f0eba57 
  lens-cli/src/test/resources/test-detail.xml PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java f0a0dfe 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java 742c6a0 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 9d5e264 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c82da7b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 077396e 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1d4e7dd 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 7d9183c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 00d92b5 
  lens-examples/src/main/resources/sales-cube.xml 4923aa3 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70bd20d 
  lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6e3afc6 

Diff: https://reviews.apache.org/r/37293/diff/


Testing
-------

Verified examples

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.468s]
[INFO] Lens .............................................. SUCCESS [3.083s]
[INFO] Lens API .......................................... SUCCESS [21.917s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.881s]
[INFO] Lens Cube ......................................... SUCCESS [6:14.198s]
[INFO] Lens DB storage ................................... SUCCESS [20.475s]
[INFO] Lens Query Library ................................ SUCCESS [15.247s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.498s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [39.033s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [15.428s]
[INFO] Lens Server ....................................... SUCCESS [5:41.025s]
[INFO] Lens client ....................................... SUCCESS [37.324s]
[INFO] Lens CLI .......................................... SUCCESS [2:33.561s]
[INFO] Lens Examples ..................................... SUCCESS [9.115s]
[INFO] Lens Distribution ................................. SUCCESS [8.490s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:19.698s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.995s]
[INFO] Lens Regression ................................... SUCCESS [10.622s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:04.962s
[INFO] Finished at: Mon Aug 10 11:08:50 UTC 2015
[INFO] Final Memory: 204M/2499M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu


Re: Review Request 37293: LENS-711 : Allow chain ref columns to have multiple chain destinations

Posted by Amareshwari Sriramadasu <am...@apache.org>.

> On Aug. 10, 2015, 11:41 a.m., Rajat Khandelwal wrote:
> > cube show joinchains might need some modifications now.

Nope. Nothing changed on chain definition. They work fine.

lens-shell>cube show fields --name sales
measures
=============================
  Name                       Display String              Description
  -------------------------  --------------------------  -----------
  line_item_discount_amount  Line item discount
  line_item_product_price    Line item product price
  line_item_quantity         Line item quantity
  line_item_tax              Line item tax
  max_line_item_discount     Maximum Line item discount
  max_line_item_price        Maximum Line item price
  rating                     Rating
  store_cost                 Store Cost
  store_sales                Store Sales
  unit_sales                 Unit Sales

dim attributes
=============================
  Name                  Display String   Description
  --------------------  ---------------  --------------------------------------------
  customer_city_id
  customer_city_name    Customer City    City name to which the customer belongs
  customer_id
  delivery_city_id
  delivery_city_name    Delivery City    City name to which the product was delivered
  delivery_time
  order_id
  order_line_number
  order_time
  product_id
  production_city_id
  production_city_name  Production City  City name in which the product was produced
  promotion_id

expr columns
=============================
  Name             Display String   Description  Expr Specs
  ---------------  ---------------  -----------  ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  profit           Profit                        always valid: store_sales - store_cost
  promotion_sales  Promotion sales               after 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = 0 then 0 else store_sales end), before 2015-04-11T23:30:00.000+05:30: sum(case when promotion_id = -1 then 0 when promotion_id = -1 then 0 else store_sales end)


lens-shell>cube show joinchains --name sales
  Name              Display String  Description  Destination Table  Path
  ----------------  --------------  -----------  -----------------  -------------------------------------------------------
  customer_details                               customer           sales.customer_id=customer.id
  customer_city                                  city               sales.customer_city_id=city.id
                                                                    sales.customer_id=customer.id->customer.city_id=city.id
  product_details                                product            sales.product_id=product.id
  production_city                                city               sales.production_city_id=city.id
  delivery_city                                  city               sales.delivery_city_id=city.id


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37293/#review94723
-----------------------------------------------------------


On Aug. 10, 2015, 11:22 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37293/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 11:22 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-711
>     https://issues.apache.org/jira/browse/LENS-711
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include :
> - Add ability to specify multiple chain columns
> - Add rewriter capability to understand multiple chains for a column
> - Rewriter tests added
> - End to end test in lens-cli
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd e6cb87d 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 9912eef 
>   lens-cli/src/test/resources/sample-cube.xml f0eba57 
>   lens-cli/src/test/resources/test-detail.xml PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java 742c6a0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 077396e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1d4e7dd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 7d9183c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 00d92b5 
>   lens-examples/src/main/resources/sales-cube.xml 4923aa3 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70bd20d 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6e3afc6 
> 
> Diff: https://reviews.apache.org/r/37293/diff/
> 
> 
> Testing
> -------
> 
> Verified examples
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.468s]
> [INFO] Lens .............................................. SUCCESS [3.083s]
> [INFO] Lens API .......................................... SUCCESS [21.917s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.881s]
> [INFO] Lens Cube ......................................... SUCCESS [6:14.198s]
> [INFO] Lens DB storage ................................... SUCCESS [20.475s]
> [INFO] Lens Query Library ................................ SUCCESS [15.247s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.498s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.033s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.428s]
> [INFO] Lens Server ....................................... SUCCESS [5:41.025s]
> [INFO] Lens client ....................................... SUCCESS [37.324s]
> [INFO] Lens CLI .......................................... SUCCESS [2:33.561s]
> [INFO] Lens Examples ..................................... SUCCESS [9.115s]
> [INFO] Lens Distribution ................................. SUCCESS [8.490s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.698s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.995s]
> [INFO] Lens Regression ................................... SUCCESS [10.622s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:04.962s
> [INFO] Finished at: Mon Aug 10 11:08:50 UTC 2015
> [INFO] Final Memory: 204M/2499M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>


Re: Review Request 37293: LENS-711 : Allow chain ref columns to have multiple chain destinations

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37293/#review94723
-----------------------------------------------------------


cube show joinchains might need some modifications now.

- Rajat Khandelwal


On Aug. 10, 2015, 4:52 p.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37293/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 4:52 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-711
>     https://issues.apache.org/jira/browse/LENS-711
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include :
> - Add ability to specify multiple chain columns
> - Add rewriter capability to understand multiple chains for a column
> - Rewriter tests added
> - End to end test in lens-cli
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd e6cb87d 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 9912eef 
>   lens-cli/src/test/resources/sample-cube.xml f0eba57 
>   lens-cli/src/test/resources/test-detail.xml PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java 742c6a0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 077396e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1d4e7dd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 7d9183c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 00d92b5 
>   lens-examples/src/main/resources/sales-cube.xml 4923aa3 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70bd20d 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6e3afc6 
> 
> Diff: https://reviews.apache.org/r/37293/diff/
> 
> 
> Testing
> -------
> 
> Verified examples
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.468s]
> [INFO] Lens .............................................. SUCCESS [3.083s]
> [INFO] Lens API .......................................... SUCCESS [21.917s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.881s]
> [INFO] Lens Cube ......................................... SUCCESS [6:14.198s]
> [INFO] Lens DB storage ................................... SUCCESS [20.475s]
> [INFO] Lens Query Library ................................ SUCCESS [15.247s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.498s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.033s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.428s]
> [INFO] Lens Server ....................................... SUCCESS [5:41.025s]
> [INFO] Lens client ....................................... SUCCESS [37.324s]
> [INFO] Lens CLI .......................................... SUCCESS [2:33.561s]
> [INFO] Lens Examples ..................................... SUCCESS [9.115s]
> [INFO] Lens Distribution ................................. SUCCESS [8.490s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.698s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.995s]
> [INFO] Lens Regression ................................... SUCCESS [10.622s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:04.962s
> [INFO] Finished at: Mon Aug 10 11:08:50 UTC 2015
> [INFO] Final Memory: 204M/2499M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>


Re: Review Request 37293: LENS-711 : Allow chain ref columns to have multiple chain destinations

Posted by Amareshwari Sriramadasu <am...@apache.org>.

> On Aug. 10, 2015, 11:48 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java, line 273
> > <https://reviews.apache.org/r/37293/diff/1/?file=1036171#file1036171line273>
> >
> >     Shoould we throw LensException here? LENS-187 will remove all SemanticExceptions.

Newer error codes and signature change wrt LensException are part of LENS-187. Mostly it needs to be fixed in LENS-187, if this patch goes first.


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37293/#review94724
-----------------------------------------------------------


On Aug. 11, 2015, 5:02 a.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37293/
> -----------------------------------------------------------
> 
> (Updated Aug. 11, 2015, 5:02 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-711
>     https://issues.apache.org/jira/browse/LENS-711
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include :
> - Add ability to specify multiple chain columns
> - Add rewriter capability to understand multiple chains for a column
> - Rewriter tests added
> - End to end test in lens-cli
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd e6cb87d 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 9912eef 
>   lens-cli/src/test/resources/sample-cube.xml f0eba57 
>   lens-cli/src/test/resources/test-detail.xml PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java f0a0dfe 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java 742c6a0 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java 9d5e264 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c82da7b 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 077396e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1d4e7dd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 7d9183c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 00d92b5 
>   lens-examples/src/main/resources/sales-cube.xml 4923aa3 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70bd20d 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6e3afc6 
> 
> Diff: https://reviews.apache.org/r/37293/diff/
> 
> 
> Testing
> -------
> 
> Verified examples
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.468s]
> [INFO] Lens .............................................. SUCCESS [3.083s]
> [INFO] Lens API .......................................... SUCCESS [21.917s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.881s]
> [INFO] Lens Cube ......................................... SUCCESS [6:14.198s]
> [INFO] Lens DB storage ................................... SUCCESS [20.475s]
> [INFO] Lens Query Library ................................ SUCCESS [15.247s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.498s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.033s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.428s]
> [INFO] Lens Server ....................................... SUCCESS [5:41.025s]
> [INFO] Lens client ....................................... SUCCESS [37.324s]
> [INFO] Lens CLI .......................................... SUCCESS [2:33.561s]
> [INFO] Lens Examples ..................................... SUCCESS [9.115s]
> [INFO] Lens Distribution ................................. SUCCESS [8.490s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.698s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.995s]
> [INFO] Lens Regression ................................... SUCCESS [10.622s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:04.962s
> [INFO] Finished at: Mon Aug 10 11:08:50 UTC 2015
> [INFO] Final Memory: 204M/2499M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>


Re: Review Request 37293: LENS-711 : Allow chain ref columns to have multiple chain destinations

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37293/#review94724
-----------------------------------------------------------



lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java (line 271)
<https://reviews.apache.org/r/37293/#comment149340>

    Shoould we throw LensException here? LENS-187 will remove all SemanticExceptions.



lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java (lines 1389 - 1395)
<https://reviews.apache.org/r/37293/#comment149341>

    Commented code


- Rajat Khandelwal


On Aug. 10, 2015, 4:52 p.m., Amareshwari Sriramadasu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37293/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2015, 4:52 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-711
>     https://issues.apache.org/jira/browse/LENS-711
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes include :
> - Add ability to specify multiple chain columns
> - Add rewriter capability to understand multiple chains for a column
> - Rewriter tests added
> - End to end test in lens-cli
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd e6cb87d 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 9912eef 
>   lens-cli/src/test/resources/sample-cube.xml f0eba57 
>   lens-cli/src/test/resources/test-detail.xml PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java 742c6a0 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 50a4d53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 4a95d5a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 03377dd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 7d04d19 
>   lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 077396e 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 1d4e7dd 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java f65bd28 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java 7d9183c 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java 00d92b5 
>   lens-examples/src/main/resources/sales-cube.xml 4923aa3 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 70bd20d 
>   lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 6e3afc6 
> 
> Diff: https://reviews.apache.org/r/37293/diff/
> 
> 
> Testing
> -------
> 
> Verified examples
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.468s]
> [INFO] Lens .............................................. SUCCESS [3.083s]
> [INFO] Lens API .......................................... SUCCESS [21.917s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.881s]
> [INFO] Lens Cube ......................................... SUCCESS [6:14.198s]
> [INFO] Lens DB storage ................................... SUCCESS [20.475s]
> [INFO] Lens Query Library ................................ SUCCESS [15.247s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.498s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.033s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.428s]
> [INFO] Lens Server ....................................... SUCCESS [5:41.025s]
> [INFO] Lens client ....................................... SUCCESS [37.324s]
> [INFO] Lens CLI .......................................... SUCCESS [2:33.561s]
> [INFO] Lens Examples ..................................... SUCCESS [9.115s]
> [INFO] Lens Distribution ................................. SUCCESS [8.490s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.698s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.995s]
> [INFO] Lens Regression ................................... SUCCESS [10.622s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:04.962s
> [INFO] Finished at: Mon Aug 10 11:08:50 UTC 2015
> [INFO] Final Memory: 204M/2499M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>