You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/07 18:04:40 UTC

[GitHub] [tvm] masahi commented on pull request #7044: [TOPI] GPU scatter_add using atomic

masahi commented on pull request #7044:
URL: https://github.com/apache/tvm/pull/7044#issuecomment-740084249


   > What kind of perf improvement do you see with this?
   
   Well, the comparison would be a bit embarrassing, since the current one is the worst gpu kernel ever :) Below is an excerpt from nvprof log. This result is obtained on my crappy laptop gpu, but the difference is still significant (5 ms vs 20 us).  
   
   Current one
   ```
   Duration  Grid Size  Block Size Name
   5.5576ms  (1 1 1)    (1 1 1)    fused_scatter_add_1_kernel1
   ```
   
   New one in this PR
   ```                                                                                                                                                                                                                                                                                                                                              
   Duration  Grid Size  Block Size Name
   22.176us  (10 1 1)   (1024 1 1) fused_scatter_add_1_kernel1
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org