You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/09/27 13:07:13 UTC
[GitHub] [inlong] vernedeng opened a new pull request, #6043: [INLONG-6042][Manager] Support delete DataNode by name
vernedeng opened a new pull request, #6043:
URL: https://github.com/apache/inlong/pull/6043
### Prepare a Pull Request
*(Change the title refer to the following example)*
- Title Example: [INLONG-XYZ][Component] Title of the pull request
*(The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)*
- Fixes #6042
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #6043: [INLONG-6042][Manager] Support delete and update DataNode by unique key
Posted by GitBox <gi...@apache.org>.
healchow merged PR #6043:
URL: https://github.com/apache/inlong/pull/6043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6043: [INLONG-6042][Manager] Support delete DataNode by name
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6043:
URL: https://github.com/apache/inlong/pull/6043#discussion_r983284343
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/inner/client/DataNodeClient.java:
##########
@@ -107,4 +107,17 @@ public Boolean delete(Integer id) {
return response.getData();
}
+ /**
+ * Delete data node by name.
+ *
+ * @param name node name to be deleted
+ * @return whether succeed
+ */
+ public Boolean delete(String name) {
Review Comment:
Please specify the data node type at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6043: [INLONG-6042][Manager] Support delete DataNode by name
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6043:
URL: https://github.com/apache/inlong/pull/6043#discussion_r983283632
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/DataNodeServiceImpl.java:
##########
@@ -142,6 +142,20 @@ public Boolean delete(Integer id, String operator) {
return false;
}
+ return delete(entity, operator);
+ }
+
+ @Override
+ public Boolean deleteByName(String name, String operator) {
+ DataNodeEntity entity = dataNodeMapper.selectByNameAndType(name, null);
Review Comment:
There may return more than one entity.
Suggested make tye type not null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #6043: [INLONG-6042][Manager] Support delete DataNode by name
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #6043:
URL: https://github.com/apache/inlong/pull/6043#discussion_r990722038
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/custom/CustomDataNodeOperator.java:
##########
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.manager.service.node.custom;
+
+import org.apache.inlong.manager.common.consts.DataNodeType;
+import org.apache.inlong.manager.common.enums.ErrorCodeEnum;
+import org.apache.inlong.manager.common.exceptions.BusinessException;
+import org.apache.inlong.manager.common.util.CommonBeanUtils;
+import org.apache.inlong.manager.dao.entity.DataNodeEntity;
+import org.apache.inlong.manager.pojo.node.DataNodeInfo;
+import org.apache.inlong.manager.pojo.node.DataNodeRequest;
+import org.apache.inlong.manager.pojo.node.custom.CustomDataNodeInfo;
+import org.apache.inlong.manager.service.node.AbstractDataNodeOperator;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.stereotype.Service;
+
+/**
+ * Custom data node operator
+ */
+@Service
+public class CustomDataNodeOperator extends AbstractDataNodeOperator {
Review Comment:
What is the relation between the `delete data node` and `custom data node`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] vernedeng commented on a diff in pull request #6043: [INLONG-6042][Manager] Support delete DataNode by name
Posted by GitBox <gi...@apache.org>.
vernedeng commented on code in PR #6043:
URL: https://github.com/apache/inlong/pull/6043#discussion_r983424962
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/node/DataNodeServiceImpl.java:
##########
@@ -142,6 +142,20 @@ public Boolean delete(Integer id, String operator) {
return false;
}
+ return delete(entity, operator);
+ }
+
+ @Override
+ public Boolean deleteByName(String name, String operator) {
+ DataNodeEntity entity = dataNodeMapper.selectByNameAndType(name, null);
Review Comment:
fixed, thx
##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/inner/client/DataNodeClient.java:
##########
@@ -107,4 +107,17 @@ public Boolean delete(Integer id) {
return response.getData();
}
+ /**
+ * Delete data node by name.
+ *
+ * @param name node name to be deleted
+ * @return whether succeed
+ */
+ public Boolean delete(String name) {
Review Comment:
fixed, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org