You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@apex.apache.org by "Sanjay M Pujare (JIRA)" <ji...@apache.org> on 2016/07/01 00:01:33 UTC

[jira] [Commented] (APEXMALHAR-2069) FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization from constructor to setup

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358074#comment-15358074 ] 

Sanjay M Pujare commented on APEXMALHAR-2069:
---------------------------------------------

[~csingh] Can you comment on how we can redesign the tests after this change? The failing tests are:

  FileSplitterInputTest.testFirstWindowAfterRecovery:353->testIdempotencyWithBlocksThreshold:336 
  FileSplitterInputTest.testIdempotency:231 » Runtime multiple calls to setup() ...
  FileSplitterInputTest.testIdempotencyWithBlocksThreshold:336 » Runtime multipl...
  FileSplitterInputTest.testRecoveryOfBlockMetadataIterator:517 » Runtime multip...

> FileSplitterInput and TimeBasedDirectoryScanner - move operational fields initialization from constructor to setup
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: APEXMALHAR-2069
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2069
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Vlad Rozov
>
> For example, there is no need for scanService to be initialized in the constructor. It should be done during operator setup().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)