[GitHub] Antonio-Maranhao commented on a change in pull request #1062: Remove JQuery usage from config addon

[GitBox <gi...@apache.org>]

Antonio-Maranhao commented on a change in pull request #1062: Remove JQuery usage from config addon
URL: https://github.com/apache/couchdb-fauxton/pull/1062#discussion_r173808034
 
 

 ##########
 File path: app/addons/config/components.js
 ##########
 @@ -248,13 +252,12 @@ class ConfigOptionTrash extends React.Component {
 
   render() {
     return (
-      <td className="text-center config-item-trash config-delete-value"
-        onClick={this.showModal.bind(this)}>
-        <i className="icon icon-trash"></i>
+      <td className="text-center config-item-trash config-delete-value">
+        <i className="icon icon-trash" onClick={this.showModal}></i>
 
 Review comment:
   @popojargo Yes. Having the onClick inside `<td>` was causing it to be fired if you clicked any where on the modal (even the gray background). Meaning, the modal couldn't be closed when clicking on Cancel or the X button because it trigged the event to show the modal again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services