Change in asterixdb[master]: [ASTERIXDB-2516][RT] Move primitive comparators to Hyracks and make s...

["Dmitry Lychagin (Code Review)" <de...@asterixdb.apache.org>]

Dmitry Lychagin has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/3294 )

Change subject: [ASTERIXDB-2516][RT] Move primitive comparators to Hyracks and make singleton
......................................................................


Patch Set 5: Code-Review+2

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3294/5/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/BooleanPointable.java
File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/BooleanPointable.java:

https://asterix-gerrit.ics.uci.edu/#/c/3294/5/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/BooleanPointable.java@36
PS5, Line 36:     private static final int LENGTH = 1;
> MAJOR SonarQube violation:
minor. I think we should address this and rename the LENGTH field here and in other Pointables (call it SIZE, or something else)


https://asterix-gerrit.ics.uci.edu/#/c/3294/5/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/utils/SerdeUtils.java
File hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/utils/SerdeUtils.java:

https://asterix-gerrit.ics.uci.edu/#/c/3294/5/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/utils/SerdeUtils.java@129
PS5, Line 129:             // TODO(ali): how come?
minor. can we just return BooleanBinaryComparatorFactory.INSTANCE  here to be consistent?



-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3294
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If15dc4e0dd0db942a4cadb15abbe56cbfe617b48
Gerrit-Change-Number: 3294
Gerrit-PatchSet: 5
Gerrit-Owner: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mh...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Comment-Date: Thu, 11 Apr 2019 22:46:25 +0000
Gerrit-HasComments: Yes