[GitHub] [james-project] LanKhuat commented on a change in pull request #318: JAMES-3492 ElasticSearch 7 mailbox tests adaptation

[GitBox <gi...@apache.org>]

LanKhuat commented on a change in pull request #318:
URL: https://github.com/apache/james-project/pull/318#discussion_r588193048



##########
File path: backends-common/elasticsearch-v7/src/main/java/org/apache/james/backends/es/v7/NodeMappingFactory.java
##########
@@ -60,18 +59,18 @@ public static ReactorElasticSearchClient applyMapping(ReactorElasticSearchClient
         return client;
     }
 
-    // ElasticSearch 6.3.2 does not support field master_timeout that is set up by 6.4.3 REST client when relying on getMapping
-    @SuppressWarnings("deprecation")
     public static boolean mappingAlreadyExist(ReactorElasticSearchClient client, IndexName indexName) throws IOException {

Review comment:
       i don't think so. Only used in tests now. Should we remove this class along with all its tests?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org