You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by jm...@apache.org on 2005/03/02 07:04:31 UTC
svn commit: r155885 - in
struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient:
ContextTestCase.java LogonTestCase.java SimpleTestCase.java
Author: jmitchell
Date: Tue Mar 1 22:04:30 2005
New Revision: 155885
URL: http://svn.apache.org/viewcvs?view=rev&rev=155885
Log:
Many small improvements thanks to our new maven reports
- unused import(s)
- useless object creation
- unnecessary casting
Modified:
struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/ContextTestCase.java
struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/LogonTestCase.java
struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/SimpleTestCase.java
Modified: struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/ContextTestCase.java
URL: http://svn.apache.org/viewcvs/struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/ContextTestCase.java?view=diff&r1=155884&r2=155885
==============================================================================
--- struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/ContextTestCase.java (original)
+++ struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/ContextTestCase.java Tue Mar 1 22:04:30 2005
@@ -16,31 +16,11 @@
package org.apache.struts.faces.sysclient;
-import com.gargoylesoftware.htmlunit.ElementNotFoundException;
-import com.gargoylesoftware.htmlunit.WebClient;
-import com.gargoylesoftware.htmlunit.html.HtmlAnchor;
-import com.gargoylesoftware.htmlunit.html.HtmlBase;
-import com.gargoylesoftware.htmlunit.html.HtmlBody;
-import com.gargoylesoftware.htmlunit.html.HtmlElement;
-import com.gargoylesoftware.htmlunit.html.HtmlForm;
-import com.gargoylesoftware.htmlunit.html.HtmlHead;
-import com.gargoylesoftware.htmlunit.html.HtmlHiddenInput;
-import com.gargoylesoftware.htmlunit.html.HtmlLink;
-import com.gargoylesoftware.htmlunit.html.HtmlPage;
-import com.gargoylesoftware.htmlunit.html.HtmlPasswordInput;
-import com.gargoylesoftware.htmlunit.html.HtmlResetInput;
-import com.gargoylesoftware.htmlunit.html.HtmlSpan;
-import com.gargoylesoftware.htmlunit.html.HtmlSubmitInput;
-import com.gargoylesoftware.htmlunit.html.HtmlTextInput;
-
-import java.net.URL;
-import java.util.ArrayList;
-import java.util.Iterator;
-import java.util.List;
-
import junit.framework.Test;
-import junit.framework.TestCase;
import junit.framework.TestSuite;
+
+import com.gargoylesoftware.htmlunit.html.HtmlSpan;
+import com.gargoylesoftware.htmlunit.html.HtmlSubmitInput;
/**
Modified: struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/LogonTestCase.java
URL: http://svn.apache.org/viewcvs/struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/LogonTestCase.java?view=diff&r1=155884&r2=155885
==============================================================================
--- struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/LogonTestCase.java (original)
+++ struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/LogonTestCase.java Tue Mar 1 22:04:30 2005
@@ -16,32 +16,21 @@
package org.apache.struts.faces.sysclient;
-import com.gargoylesoftware.htmlunit.ElementNotFoundException;
-import com.gargoylesoftware.htmlunit.WebClient;
+import java.util.List;
+
+import junit.framework.Test;
+import junit.framework.TestSuite;
+
import com.gargoylesoftware.htmlunit.html.HtmlAnchor;
-import com.gargoylesoftware.htmlunit.html.HtmlBase;
-import com.gargoylesoftware.htmlunit.html.HtmlBody;
import com.gargoylesoftware.htmlunit.html.HtmlElement;
import com.gargoylesoftware.htmlunit.html.HtmlForm;
-import com.gargoylesoftware.htmlunit.html.HtmlHead;
import com.gargoylesoftware.htmlunit.html.HtmlHiddenInput;
-import com.gargoylesoftware.htmlunit.html.HtmlLink;
-import com.gargoylesoftware.htmlunit.html.HtmlPage;
import com.gargoylesoftware.htmlunit.html.HtmlPasswordInput;
import com.gargoylesoftware.htmlunit.html.HtmlResetInput;
import com.gargoylesoftware.htmlunit.html.HtmlSpan;
import com.gargoylesoftware.htmlunit.html.HtmlSubmitInput;
import com.gargoylesoftware.htmlunit.html.HtmlTextInput;
-import java.net.URL;
-import java.util.ArrayList;
-import java.util.Iterator;
-import java.util.List;
-
-import junit.framework.Test;
-import junit.framework.TestCase;
-import junit.framework.TestSuite;
-
/**
* <p>Test case for a logon form that accepts a username and password.</p>
@@ -165,7 +154,7 @@
HtmlSpan span = null;
- HtmlElement html = (HtmlElement) page;
+ HtmlElement html = page;
assertEquals("html", html.getTagName());
assertEquals("http://www.w3.org/1999/xhtml", html.getAttributeValue("xmlns"));
Modified: struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/SimpleTestCase.java
URL: http://svn.apache.org/viewcvs/struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/SimpleTestCase.java?view=diff&r1=155884&r2=155885
==============================================================================
--- struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/SimpleTestCase.java (original)
+++ struts/faces/trunk/sysclient-app/src/java/org/apache/struts/faces/sysclient/SimpleTestCase.java Tue Mar 1 22:04:30 2005
@@ -16,26 +16,16 @@
package org.apache.struts.faces.sysclient;
-import com.gargoylesoftware.htmlunit.ElementNotFoundException;
-import com.gargoylesoftware.htmlunit.WebClient;
-import com.gargoylesoftware.htmlunit.html.HtmlBase;
-import com.gargoylesoftware.htmlunit.html.HtmlBody;
-import com.gargoylesoftware.htmlunit.html.HtmlElement;
-import com.gargoylesoftware.htmlunit.html.HtmlForm;
-import com.gargoylesoftware.htmlunit.html.HtmlHead;
-import com.gargoylesoftware.htmlunit.html.HtmlLink;
-import com.gargoylesoftware.htmlunit.html.HtmlPage;
-import com.gargoylesoftware.htmlunit.html.HtmlSpan;
-
-import java.net.URL;
-import java.util.ArrayList;
import java.util.Iterator;
-import java.util.List;
import junit.framework.Test;
-import junit.framework.TestCase;
import junit.framework.TestSuite;
+import com.gargoylesoftware.htmlunit.html.HtmlBase;
+import com.gargoylesoftware.htmlunit.html.HtmlElement;
+import com.gargoylesoftware.htmlunit.html.HtmlLink;
+import com.gargoylesoftware.htmlunit.html.HtmlSpan;
+
/**
* <p>Test case for a simple Struts-Faces page that is statically examined
@@ -130,7 +120,7 @@
*/
public void testHtml() throws Exception {
- HtmlElement html = (HtmlElement) page;
+ HtmlElement html = page;
assertEquals("html", html.getTagName());
assertEquals("http://www.w3.org/1999/xhtml", html.getAttributeValue("xmlns"));
// TODO: verify the "lang" attribute
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org