You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/07/19 20:27:14 UTC

[GitHub] [trafficserver] shinrich commented on a change in pull request #8049: Add PS debug to store requesting URL and add to notes

shinrich commented on a change in pull request #8049:
URL: https://github.com/apache/trafficserver/pull/8049#discussion_r672607211



##########
File path: proxy/ParentSelection.cc
##########
@@ -126,6 +127,9 @@ ParentConfigParams::findParent(HttpRequestData *rdata, ParentResult *result, uns
   tablePtr->Match(rdata, result);
   rec = result->rec;
 
+  // Set the result url string to store the URL request that initiated this
+  result->url = rdata->get_string();

Review comment:
       By code inspection, the pointer returned by rdata->get_string() is stable because it is allocated in hdr->url_string_get() which is called from rdata->get_string().
   
   So as the code in this PR stands, things are stable, but you need to add logic to free the result->url.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org