You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/14 14:24:00 UTC

[GitHub] [nifi] pvillard31 commented on a change in pull request #2997: NIFI-5583: Add cdc processor for MySQL referring to GTID.

pvillard31 commented on a change in pull request #2997:
URL: https://github.com/apache/nifi/pull/2997#discussion_r487972597



##########
File path: nifi-nar-bundles/nifi-cdc/nifi-cdc-mysql-bundle/nifi-cdc-mysql-processors/src/main/java/org/apache/nifi/cdc/mysql/processors/CaptureChangeMySQL.java
##########
@@ -681,6 +731,9 @@ protected void connect(List<InetSocketAddress> hosts, String username, String pa
                 binlogClient.setBinlogPosition(currentBinlogPosition);
             }
 
+            binlogClient.setGtidSet(currentGtidSet);
+            binlogClient.setGtidSetFallbackToPurged(true);

Review comment:
       Is it what we want here? https://github.com/shyiko/mysql-binlog-connector-java/blob/master/src/main/java/com/github/shyiko/mysql/binlog/BinaryLogClient.java#L331




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org