You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/12/26 08:30:12 UTC
[GitHub] [incubator-devlake] klesh opened a new pull request, #4027: PoC Jira Server PAT support
klesh opened a new pull request, #4027:
URL: https://github.com/apache/incubator-devlake/pull/4027
### Summary
Currently, we support only `Basic Authentication` for Jira Cloud/Server, it worked fine for most of our users.
However, some might run into a situation the their Jira Server support PAT only for security reason which makes it impossible for devlake to collect data.
### Does this close any open issues?
This is a PoC to verify if it is possible to collect data by using Jira PAT in a hacky way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #4027: PoC Jira Server PAT support
Posted by GitBox <gi...@apache.org>.
keon94 commented on code in PR #4027:
URL: https://github.com/apache/incubator-devlake/pull/4027#discussion_r1072585955
##########
plugins/jira/tasks/api_client.go:
##########
@@ -32,6 +33,9 @@ func NewJiraApiClient(taskCtx core.TaskContext, connection *models.JiraConnectio
headers := map[string]string{
"Authorization": fmt.Sprintf("Basic %v", connection.GetEncodedToken()),
}
+ if connection.Username == "_BEARER_TOKEN_" {
Review Comment:
maybe put line 33 in an else block, so we're not double-writing the same key to the map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh commented on pull request #4027: PoC Jira Server PAT support
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh commented on PR #4027:
URL: https://github.com/apache/incubator-devlake/pull/4027#issuecomment-1407614968
@keon94 This is a temporary fix, not meant to be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] klesh closed pull request #4027: PoC Jira Server PAT support
Posted by "klesh (via GitHub)" <gi...@apache.org>.
klesh closed pull request #4027: PoC Jira Server PAT support
URL: https://github.com/apache/incubator-devlake/pull/4027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org