You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2015/09/16 20:03:46 UTC
[jira] [Commented] (SLING-4634) Directly check if view is still
current
[ https://issues.apache.org/jira/browse/SLING-4634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14790821#comment-14790821 ]
Carsten Ziegeler commented on SLING-4634:
-----------------------------------------
As noted in SLING-4761, the topology implementation is actually acting correct, what happens is:
- if properties change, a properties changed event is sent with a new view which make the new view the current one, the old view returning false for is current
- as the JobManagerConfiguration class is ignoring some properties changed events (which are not relevant for the job handling), it might happen that:
- a valid change event is sent which is then processed async (10 sec delay)
- within that delay a prop change event arrives which is discarded
- once the async thread starts, that view is not current anymore
I've created a test case verifying that behaviour and based on this fixed the implementation.
The only downside is now that every event in the topology causes the job handling to sleep for 10 seconds
FYI [~egli]
> Directly check if view is still current
> ---------------------------------------
>
> Key: SLING-4634
> URL: https://issues.apache.org/jira/browse/SLING-4634
> Project: Sling
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: Event 3.6.0
> Reporter: Carsten Ziegeler
> Assignee: Carsten Ziegeler
> Fix For: Event 3.7.6
>
>
> Currently, the job handler continues until it receives a topology event (changing/changed/init). However , the current view object can directly be checked whether it's current
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)