You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/03/30 09:38:56 UTC

[GitHub] [ignite] rkondakov commented on a change in pull request #7580: IGNITE-12815: SQL query cancel command.

rkondakov commented on a change in pull request #7580: IGNITE-12815: SQL query cancel command.
URL: https://github.com/apache/ignite/pull/7580#discussion_r400056416
 
 

 ##########
 File path: modules/core/src/test/java/org/apache/ignite/internal/commandline/CommandHandlerParsingTest.java
 ##########
 @@ -532,6 +533,15 @@ public void testKillArguments() {
 
         // Service command format errors.
         assertParseArgsThrows("Expected service name.", "--kill", "service");
+
+        // Transaction command format errors.
+        assertParseArgsThrows("Expected transaction id.", "--kill", "tx");
 
 Review comment:
   Do we have positive parsing tests to ensure that all arguments are parsed well? As well as tests that ensure the wrong argument types are handled gracefully? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services